fix(kubernetes): improve error messaging around invalid service names

spinnaker · Aug 23, 2019 · 831e118 · 831e118
1 parent 287b7bf
commit 831e118
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/...ouddriver/kubernetes/v2/op/manifest/AbstractKubernetesEnableDisableManifestOperation.java b/...ouddriver/kubernetes/v2/op/manifest/AbstractKubernetesEnableDisableManifestOperation.java
@@ -78,7 +78,9 @@ private void op(String loadBalancerName, KubernetesManifest target) {
       name = KubernetesManifest.fromFullResourceName(loadBalancerName);
     } catch (IllegalArgumentException e) {
       throw new IllegalArgumentException(
-          "Load balancers must be specified in the form '<kind> <name>', e.g. 'service my-service'",
+          String.format(
+              "Failed to perform operation with load balancer '%s'. Load balancers must be specified in the form '{kind} {name}', e.g. 'service my-service'",
+              loadBalancerName),
           e);
     }
 

diff --git a/...ix/spinnaker/clouddriver/kubernetes/v2/op/manifest/KubernetesDeployManifestOperation.java b/...ix/spinnaker/clouddriver/kubernetes/v2/op/manifest/KubernetesDeployManifestOperation.java
@@ -269,7 +269,9 @@ private void attachLoadBalancer(String loadBalancerName, KubernetesManifest targ
       name = KubernetesManifest.fromFullResourceName(loadBalancerName);
     } catch (IllegalArgumentException e) {
       throw new IllegalArgumentException(
-          "Load balancers must be specified in the form '<kind> <name>', e.g. 'service my-service'",
+          String.format(
+              "Failed to attach load balancer '%s'. Load balancers must be specified in the form '{kind} {name}', e.g. 'service my-service'.",
+              loadBalancerName),
           e);
     }