-
Notifications
You must be signed in to change notification settings - Fork 1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
refactor(artifacts): Update artifact code to use new metadata accessor (
#4645) * refactor(kubernetes): Avoid mutating artifact metadata There's only one place where we mutate the artifact metadata map, and it's in the Kubernetes provider. Rather than get an artifact then add the metadata later, let's just move the logic to add that metdata to the place where we create the artifact, avoiding the need to mutate the metadata. * refactor(artifacts): Update artifact code to use new metadata accessor The accessor to get the full metadata of an artifact as a map is deprecated; replace calls to it with the accessor for a specific key. The reason the function to return the entire map is deprecated is so that we can eventually make the map immutable; it's much safer to make that change if we've first updated callers to be unaware that the map exists at all an instead give them a function to get the information they want. In most cases this actually simplifies the calling code as we can remove null-checks that are now handled by the exposed API function.
- Loading branch information
Showing
7 changed files
with
13 additions
and
38 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters