Skip to content

Commit

Permalink
feat(kubernetes): permit multiple ReplicaSets to be deployed with a s…
Browse files Browse the repository at this point in the history
…ingle rollout strategy config (#4126)
  • Loading branch information
maggieneterval authored and mergify[bot] committed Oct 29, 2019
1 parent 6ab4288 commit eb301a8
Showing 1 changed file with 0 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,6 @@ public OperationResult operate(List _unused) {

Set<Artifact> boundArtifacts = new HashSet<>();

validateManifestsForRolloutStrategies(inputManifests);

for (KubernetesManifest manifest : inputManifests) {
if (credentials.getKindRegistry().getKindProperties(manifest.getKind()).isNamespaced()) {
if (!StringUtils.isEmpty(description.getNamespaceOverride())) {
Expand Down Expand Up @@ -251,15 +249,6 @@ private void applyTraffic(KubernetesManifestTraffic traffic, KubernetesManifest
traffic.getLoadBalancers().forEach(l -> attachLoadBalancer(l, target));
}

private void validateManifestsForRolloutStrategies(List<KubernetesManifest> manifests) {
long numReplicaSets =
manifests.stream().filter(m -> m.getKind().equals(KubernetesKind.REPLICA_SET)).count();
if (description.getStrategy() != null && numReplicaSets != 1) {
throw new RuntimeException(
"Spinnaker can manage traffic for one ReplicaSet only. Please deploy one ReplicaSet manifest or disable rollout strategies.");
}
}

private void attachLoadBalancer(String loadBalancerName, KubernetesManifest target) {
Pair<KubernetesKind, String> name;
try {
Expand Down

0 comments on commit eb301a8

Please sign in to comment.