Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(gce): Add a wrapper around compute.instanceTemplates() #3790

Merged
merged 4 commits into from
Jun 17, 2019
Merged

refactor(gce): Add a wrapper around compute.instanceTemplates() #3790

merged 4 commits into from
Jun 17, 2019

Conversation

plumpy
Copy link
Member

@plumpy plumpy commented Jun 14, 2019

@ezimanyi ezimanyi self-requested a review June 14, 2019 20:19
ezimanyi
ezimanyi approved these changes Jun 17, 2019
View reviewed changes
Copy link
Contributor

@ezimanyi ezimanyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Only comment is the new files don't have header block comments.

@plumpy
Copy link
Member Author

plumpy commented Jun 17, 2019

Oops, added copyright headers to everything in the 'compute' directory (new and old).

@ezimanyi ezimanyi merged commit 8d33935 into spinnaker:master Jun 17, 2019
@plumpy plumpy deleted the more_compute_api_work branch June 17, 2019 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezimanyi ezimanyi ezimanyi approved these changes

Assignees
No one assigned
Labels
target-release/1.15
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@plumpy @ezimanyi @spinnakerbot