-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(provider/aws): Fix lifecycle hooks racing condition #4082
Conversation
3ba2d95
to
661f6f0
Compare
The following commits need their title changed:
Please format your commit title into the form:
This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here. |
@robzienert @ajordens @dreynaud @cfieber please have a look at this small but meaningful bug fix. This fixes the issue caused by the fact that the auto scale group is scaled out before the lifecycle hooks are attached to the ASG. This opened the door for a race condition, where an instance was sometimes created before the lifecycle hooks were attached. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup yup yup. One change.
...er-aws/src/main/groovy/com/netflix/spinnaker/clouddriver/aws/deploy/AutoScalingWorker.groovy
Outdated
Show resolved
Hide resolved
...groovy/com/netflix/spinnaker/clouddriver/aws/deploy/handlers/BasicAmazonDeployHandler.groovy
Show resolved
Hide resolved
Add test Signed-off-by: Costi Muraru <costimuraru@gmail.com> Update clouddriver-aws/src/main/groovy/com/netflix/spinnaker/clouddriver/aws/deploy/AutoScalingWorker.groovy Co-Authored-By: Rob Zienert <rob@robzienert.com> Signed-off-by: Constantin Muraru <cmuraru@adobe.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fix 👌
Thanks, @dreynaud @robzienert |
Fixes spinnaker/spinnaker#5001
Below you can find some Deploy stage logs, which proves that lifecycle hooks are created before scaling out the server group:
Previous logs were something like this (hooks created after scaling out):