Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(google): use Optional.ofNullable() instead of if/else #4093

Merged
merged 2 commits into from
Oct 18, 2019
Merged

refactor(google): use Optional.ofNullable() instead of if/else #4093

merged 2 commits into from
Oct 18, 2019

Conversation

plumpy
Copy link
Member

@plumpy plumpy commented Oct 15, 2019

No description provided.

maggieneterval
maggieneterval approved these changes Oct 15, 2019
View reviewed changes
Copy link
Contributor

@maggieneterval maggieneterval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍡

@plumpy plumpy added ready to merge Approved and ready for a merge and removed ready to merge Approved and ready for a merge labels Oct 15, 2019
@cfieber cfieber added the ready to merge Approved and ready for a merge label Oct 17, 2019
@plumpy
Copy link
Member Author

plumpy commented Oct 17, 2019

Honestly mostly put this up to try out @robzienert's auto-merge thing, but I feel like it doesn't work so maybe I'll just submit it 😁

@marchello2000 marchello2000 added ready to merge Approved and ready for a merge and removed ready to merge Approved and ready for a merge labels Oct 18, 2019
@mergify mergify bot merged commit 102dd48 into spinnaker:master Oct 18, 2019
@plumpy
Copy link
Member Author

plumpy commented Oct 18, 2019

It's alllliiiiiiiiiiive 🤖

@plumpy plumpy deleted the optional_of_nullable branch October 18, 2019 21:44
@marchello2000 marchello2000 added the auto merged Merged automatically by a bot label Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfieber cfieber cfieber approved these changes

@maggieneterval maggieneterval maggieneterval approved these changes

Assignees
No one assigned
Labels
auto merged Merged automatically by a bot ready to merge Approved and ready for a merge target-release/1.17
Projects
None yet
Milestone
No milestone
5 participants
@plumpy @cfieber @maggieneterval @marchello2000 @spinnakerbot