feat(cfn): delete CFN changeset if empty upon request #4101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch introduces the DeleteCloudFormationChangeSet async operation, so Orca can request to delete a CFN change set under some conditions (e.g. when it's empty, or after the change set has been executed). This will allow full control of the change set life cycle by Spinnaker.
gregjones
reviewed
Oct 17, 2019
| amazonCloudFormation.deleteChangeSet(deleteChangeSetRequest); | ||
| } catch (AmazonCloudFormationException e) { | ||
| log.error( | ||
| "Error removing change set {} on stack {}", |
There was a problem hiding this comment.
What do you think about including something from the exception in the message to give an idea why it failed?
There was a problem hiding this comment.
I think it's a good idea 🙂 I'll add the message.
|
@spinnaker/reviewers PTAL |
| task.updateStatus(BASE_PHASE, "Deleting CloudFormation ChangeSet"); | ||
| amazonCloudFormation.deleteChangeSet(deleteChangeSetRequest); | ||
| } catch (AmazonCloudFormationException e) { | ||
| log.error( |
There was a problem hiding this comment.
is it OK that this error is ignored?
There was a problem hiding this comment.
Do you mean not returning any error back to orca? Fair comment, I'll return an error so orca can handle it appropiately, probably with a retryable task 👍
...tflix/spinnaker/clouddriver/aws/deploy/ops/DeleteCloudFormationChangeSetAtomicOperation.java
Outdated
Show resolved
Hide resolved
…ver/aws/deploy/ops/DeleteCloudFormationChangeSetAtomicOperation.java Co-Authored-By: Mark Vulfson <markvu@live.com>
marchello2000
approved these changes
Oct 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces the DeleteCloudFormationChangeSet async operation,
so Orca can request to delete a CFN change set under some conditions
(e.g. when it's empty, or after the change set has been executed). This
will allow full control of the change set life cycle by Spinnaker.