fix(kubernetes): Add missing limitrange kind #4170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployments containing a limitrange time out waiting for the manifest to appear, as clouddriver is missing the entry for this kind. Ideally there would be a better way of auto-detecting kinds like this (particularly ones that don't need any custom logic) but for now just adding another Handler to handle this.
|
@spinnakerbot 🍒 ⛏ 1.17 |
1 similar comment
|
@spinnakerbot 🍒 ⛏ 1.17 |
ttomsu
pushed a commit
that referenced
this pull request
Nov 25, 2019
Deployments containing a limitrange time out waiting for the manifest to appear, as clouddriver is missing the entry for this kind. Ideally there would be a better way of auto-detecting kinds like this (particularly ones that don't need any custom logic) but for now just adding another Handler to handle this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes spinnaker/spinnaker#5139
Deployments containing a limitrange time out waiting for the manifest to appear, as clouddriver is missing the entry for this kind.
Ideally there would be a better way of auto-detecting kinds like this (particularly ones that don't need any custom logic) but for now just adding another Handler to handle this.