fix(kubernetes): do not throw NPE on NetworkPolicies with null ingres… #4172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@spinnakerbot 🍒 ⛏️ 1.17 |
spinnakerbot
pushed a commit
that referenced
this pull request
Nov 20, 2019
|
Cherry pick successful: #4173 |
ttomsu
pushed a commit
that referenced
this pull request
Nov 25, 2019
gregjones
added a commit
to gregjones/clouddriver
that referenced
this pull request
Nov 25, 2019
…ith null ports Similar to spinnaker#4172, the code is assuming that a NetworkPolicy that has an ingress will return an empty list of ports, but instead it defaults to null for this[1] and so crashes. [1] https://github.com/kubernetes-client/java/blob/master/kubernetes/src/main/java/io/kubernetes/client/openapi/models/V1NetworkPolicyIngressRule.java#L45
gregjones
added a commit
to gregjones/clouddriver
that referenced
this pull request
Nov 25, 2019
…ith null ports Similar to spinnaker#4172, the code is assuming that a NetworkPolicy that has an ingress will return an empty list of ports, but instead it defaults to null for this[1] and so crashes. [1] https://github.com/kubernetes-client/java/blob/master/kubernetes/src/main/java/io/kubernetes/client/openapi/models/V1NetworkPolicyIngressRule.java#L45
gregjones
added a commit
to gregjones/clouddriver
that referenced
this pull request
Nov 26, 2019
…ith null ports Similar to spinnaker#4172, the code is assuming that a NetworkPolicy that has an ingress will return an empty list of ports, but instead it defaults to null for this[1] and so crashes. [1] https://github.com/kubernetes-client/java/blob/master/kubernetes/src/main/java/io/kubernetes/client/openapi/models/V1NetworkPolicyIngressRule.java#L45
mergify bot
pushed a commit
that referenced
this pull request
Nov 26, 2019
…ith null ports (#4182) Similar to #4172, the code is assuming that a NetworkPolicy that has an ingress will return an empty list of ports, but instead it defaults to null for this[1] and so crashes. [1] https://github.com/kubernetes-client/java/blob/master/kubernetes/src/main/java/io/kubernetes/client/openapi/models/V1NetworkPolicyIngressRule.java#L45
spinnakerbot
pushed a commit
that referenced
this pull request
Nov 26, 2019
…ith null ports (#4182) Similar to #4172, the code is assuming that a NetworkPolicy that has an ingress will return an empty list of ports, but instead it defaults to null for this[1] and so crashes. [1] https://github.com/kubernetes-client/java/blob/master/kubernetes/src/main/java/io/kubernetes/client/openapi/models/V1NetworkPolicyIngressRule.java#L45
ttomsu
pushed a commit
that referenced
this pull request
Dec 2, 2019
…ith null ports (#4182) (#4186) Similar to #4172, the code is assuming that a NetworkPolicy that has an ingress will return an empty list of ports, but instead it defaults to null for this[1] and so crashes. [1] https://github.com/kubernetes-client/java/blob/master/kubernetes/src/main/java/io/kubernetes/client/openapi/models/V1NetworkPolicyIngressRule.java#L45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s and egress
Closes spinnaker/spinnaker#5121
NetworkPolicyresource specs to have empty or omittedingressandegressfields. In fact, wheningressoregressis set to[], Kubernetes actually nulls the field out rather than preserving the empty array.V1NetworkPolicySpecmodel from the Kubernetes Java client library to deserializeNetworkPolicies, which defaultsingressandegresstonull. It looks like we were expecting the default to be an empty list. Currently,/securityGroupsrequests fail if you've deployed anyNetworkPolicywith emptyingressoregressbecause we'll always throw an NPE when trying tostreamthese fields.