Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(saga): Handle concurrency issue when same op is sent more than once #4229

Merged
merged 3 commits into from
Dec 18, 2019

Conversation

robzienert
Copy link
Member

We experienced an issue with sagas where Orca submitted the same operation into clouddriver at the same time (separated by a few milliseconds). The second request returned a 500 due to the SQL integrity constraint violation, but the work was already being handled successfully by the other clouddriver instance.

What should happen is that the second instance returns a pointer to the original task so that Orca doesn't have to reason about its mistake and just carry on monitoring the operation that's being performed.

Also changed the duration that Kato Tasks are kept around. 1 hour is too short to be able to get notified of an error and to diagnose. 4 days seems a reasonable default so that if an error occurs EOW or on the weekend, there's still sufficient time to get information the following week.

@ajordens
Copy link
Contributor

Thanks for increasing the task cleanup interval.

@spinnakerbot
Copy link
Contributor

The following commits need their title changed:

  • f01f774: Update SqlEventRepository.kt

Please format your commit title into the form:

<type>(<scope>): <subject>, e.g. fix(kubernetes): address NPE in status check

This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here.

@robzienert robzienert added the ready to merge Approved and ready for a merge label Dec 18, 2019
@mergify mergify bot added the auto merged Merged automatically by a bot label Dec 18, 2019
Copy link
Contributor

@jonsie jonsie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 1ab574c into spinnaker:master Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merged Merged automatically by a bot ready to merge Approved and ready for a merge target-release/1.18
Projects
None yet
4 participants