fix (ecs): Unstable deployments for task definitions with more than one container (#5544)

[atyutyunnik]

The original code will not finish deployment and will eventually time out, in spite of task being successfully deployed by ECS and running (spinnaker/spinnaker#5544)

    "containers": [:

        "containers": [
            {
                "networkBindings": [],
                "networkInterfaces": [],
            },
            {
                "lastStatus": "RUNNING",
                "networkBindings": [
                    {
                        "bindIP": "0.0.0.0",
                        "containerPort": 8080,
                        "hostPort": 32773,
                        "protocol": "tcp"
                    }
            }]

[allisaurus]

can we add unit tests to verify that tasks with network bindings in containers other than the first one are correctly evaluated?

[atyutyunnik]

can we add unit tests to verify that tasks with network bindings in containers other than the first one are correctly evaluated?

Normally, that's the first thing I do when introducing a change, but I was quite in a hurry with the fix for my own purposes and I also need to figure out how these particular unit tests work.

[allisaurus]

quoting @atyutyunnik from the slack convo about this issue:

I have re-verified it with the original 1.19.0 - the problem is there, UT detects it; applied the fix - UT is happy

🎉

[clareliguori]

@spinnakerbot cherry-pick 1.19

[spinnakerbot]

Cherry pick successful: #4416

[allisaurus]

@spinnakerbot cherry-pick 1.18

[spinnakerbot]

Cherry pick failed: Command failed (cherry pick commit 2a7ad04) with exit code 1:

error: could not apply 2a7ad04fe... fix (ecs): Unstable deployments when there are more than one container in task definition (#5544) (#4409)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'

[atyutyunnik]

For 1.18, you have to use PR# 4411. PR4409 is not compatible with the code base