feat(ecs): Update Task HealthStatus logic

[piradeepk]

Updated the TaskHealthStatus to be determined using the HealthStatus of the task. If a health check is defined a container within the task, wait for the task health status to be healthy, otherwise, use the task status.

Addresses: spinnaker/spinnaker#5377

[piradeepk]

@allisaurus @clareliguori please review

[allisaurus]

@pkandasamy91 I think this should be "feat(ecs)" instead of "fix", since we're adding criteria to how task health is considered.

Also, I think this addresses spinnaker/spinnaker#5377 - can you mention that in the summary so it's explicit?

[piradeepk]

@pkandasamy91 I think this should be "feat(ecs)" instead of "fix", since we're adding criteria to how task health is considered.

Also, I think this addresses spinnaker/spinnaker#5377 - can you mention that in the summary so it's explicit?

Will update the title. I was thinking of it along the lines of task health should have been used to determine the task status in the first place so this would be a bug (considering the task is not actually successful but Spinnaker marking it a success). Thoughts?

[allisaurus]

I agree it would've been preferred that health status was always taken into account, but we're now unlocking new capabilities (utilizing container health) and also changing the behavior of a core competency (evaluating task health -> deployment success/fail).

Put another way: the behavior change is enough that I would vote against patching this to previous versions. Feels like a minor release kind of change re: expectations, etc. What do you think?

[clareliguori]

Agree on this being a feat

[piradeepk]

Put another way: the behavior change is enough that I would vote against patching this to previous versions. Feels like a minor release kind of change re: expectations, etc. What do you think?

I definitely see how it can be both a fix and a feat. I agree, we should not patch this to previous versions, as this could potentially break existing customers, and the previous behaviour might have been relied upon by customers. I'll update the pr title to be a feature.

[piradeepk]

Feedback addressed :)