Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cloudfoundry): add support for manifest random route #5383

Merged
merged 5 commits into from
Jun 15, 2021

Conversation

rvazquezglez
Copy link
Contributor

This features supports random routes which can be defined in cloud foundry manifests.

For more information about random routes see here.

@zachsmith1
Copy link
Contributor

Do you think we could just copy the list of words thats used by the cf cli and randomly pick those here as well?

Copy link
Contributor

@zachsmith1 zachsmith1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zachsmith1 zachsmith1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zachsmith1 zachsmith1 merged commit b431f10 into spinnaker:master Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants