Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cats/sql): made sharding configuration consistent #5512

Merged
merged 2 commits into from Sep 13, 2021

Conversation

kirangodishala
Copy link
Contributor

@kirangodishala kirangodishala commented Sep 7, 2021

With this change, both of the sharding implementations(sql and redis based) are in consistent with respect to configuration properties. i.e., the following properties are now common to both the implementations.

cache-sharding:
  enabled: true
  replicaTtlSeconds: 60
  heartbeatIntervalSeconds: 30

Corresponding issue - #6481

@dbyron-sf
Copy link
Contributor

Please mention this in the release notes.

@kirangodishala
Copy link
Contributor Author

Please mention this in the release notes.

done

@german-muzquiz german-muzquiz added the ready to merge Approved and ready for a merge label Sep 13, 2021
@mergify mergify bot added the auto merged Merged automatically by a bot label Sep 13, 2021
@mergify mergify bot merged commit 3c946fc into spinnaker:master Sep 13, 2021
yugaa22 pushed a commit to OpsMx/clouddriver that referenced this pull request May 16, 2022
…er consistent with redis based scheduler (spinnaker#5512)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
yugaa22 pushed a commit to OpsMx/clouddriver that referenced this pull request Jun 1, 2022
…er consistent with redis based scheduler (spinnaker#5512)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
yugaa22 pushed a commit to OpsMx/clouddriver that referenced this pull request May 31, 2023
…er consistent with redis based scheduler (spinnaker#5512)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
yugaa22 pushed a commit to OpsMx/clouddriver that referenced this pull request Sep 6, 2023
…er consistent with redis based scheduler (spinnaker#5512)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
opsmxuser pushed a commit to OpsMx/clouddriver that referenced this pull request Sep 6, 2023
…er consistent with redis based scheduler (spinnaker#5512)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merged Merged automatically by a bot ready to merge Approved and ready for a merge target-release/1.28
Projects
None yet
4 participants