feat(kubectl): Extract interface for KubectlJobExecutor and use it. #6076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stead of the implementation.
|
Please delete the pull request instructions from the body of your pull request message. The instructions start with the line:
You can reopen your pull request when this has been addressed. |
ovidiupopa07
reviewed
Oct 6, 2023
| import java.util.List; | ||
| import javax.annotation.Nonnull; | ||
|
|
||
| public interface KubectlJobExecutorInterface { |
There was a problem hiding this comment.
let's rename it to KubectlJobExecutor and the implementation to DefaultKubectlJobExecutor
…stead of the implementation.
…stead of the implementation.
…stead of the implementation.
...es/src/main/java/com/netflix/spinnaker/clouddriver/kubernetes/op/job/KubectlJobExecutor.java
Outdated
Show resolved
Hide resolved
…stead of the implementation.
ovidiupopa07
approved these changes
Oct 10, 2023
|
@mergify backport release-1.28.x |
❌ Sorry but I didn't understand the command. Please consult the commands documentation 📚. |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 17, 2023
…6076) * feat(kubectl): Extract interface for KubectlJobExecutor and use it instead of the implementation. * feat(kubectl): Extract interface for KubectlJobExecutor and use it instead of the implementation. * feat(kubectl): Extract interface for KubectlJobExecutor and use it instead of the implementation. * feat(kubectl): Extract interface for KubectlJobExecutor and use it instead of the implementation. * feat(kubectl): Extract interface for KubectlJobExecutor and use it instead of the implementation. (cherry picked from commit bb04878) # Conflicts: # clouddriver-kubernetes/src/main/java/com/netflix/spinnaker/clouddriver/kubernetes/op/handler/CanDeploy.java # clouddriver-kubernetes/src/main/java/com/netflix/spinnaker/clouddriver/kubernetes/op/job/KubectlJobExecutor.java # clouddriver-kubernetes/src/test/groovy/com/netflix/spinnaker/clouddriver/kubernetes/provider/view/KubernetesJobProviderSpec.groovy # clouddriver-kubernetes/src/test/java/com/netflix/spinnaker/clouddriver/kubernetes/op/job/DefaultKubectlJobExecutorTest.java
DanielaS12
added a commit
to armory-io/clouddriver
that referenced
this pull request
Oct 23, 2023
…pinnaker#6076) * feat(kubectl): Extract interface for KubectlJobExecutor and use it instead of the implementation. * feat(kubectl): Extract interface for KubectlJobExecutor and use it instead of the implementation. * feat(kubectl): Extract interface for KubectlJobExecutor and use it instead of the implementation. * feat(kubectl): Extract interface for KubectlJobExecutor and use it instead of the implementation. * feat(kubectl): Extract interface for KubectlJobExecutor and use it instead of the implementation. (cherry picked from commit bb04878)
DanielaS12
added a commit
to armory-io/clouddriver
that referenced
this pull request
Nov 13, 2023
…se it. (spinnaker#6076)" This reverts commit bb04878.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is made to enhance the kubernetes module to add the possibility to decorate the class. This will be usefull when extending the functionalities of the the KubectlJobExecutor in the community or using plugins.