Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Change the agent type name to not include the account name since this would generate LOTS of tables and cause problems long term (backport #6158) #6166

Merged
merged 1 commit into from Feb 27, 2024
Merged

fix: Change the agent type name to not include the account name since this would generate LOTS of tables and cause problems long term (backport #6158) #6166

merged 1 commit into from Feb 27, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 27, 2024

This is an automatic backport of pull request #6158 done by Mergify.

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@ovidiupopa07 @mergify
fix: Change the agent type name to not include the account name since…
fb2c656 
… this would generate LOTS of tables and cause problems long term (#6158)

The standard in spinnaker is to use a single table for a cache agent TYPE without the account name,

(cherry picked from commit 40bd706)
@mergify mergify bot mentioned this pull request Feb 27, 2024
Merged
@jasonmcintosh jasonmcintosh added the ready to merge Approved and ready for a merge label Feb 27, 2024
@mergify mergify bot added the auto merged Merged automatically by a bot label Feb 27, 2024
@mergify mergify bot merged commit 8f41451 into release-1.33.x Feb 27, 2024
17 checks passed
@mergify mergify bot deleted the mergify/bp/release-1.33.x/pr-6158 branch February 27, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonmcintosh jasonmcintosh jasonmcintosh approved these changes

@jeyrschabu jeyrschabu Awaiting requested review from jeyrschabu jeyrschabu is a code owner

@ajordens ajordens Awaiting requested review from ajordens ajordens is a code owner

Assignees
No one assigned
Labels
auto merged Merged automatically by a bot ready to merge Approved and ready for a merge target-release/1.33
Projects
None yet
Milestone
No milestone
3 participants
@jasonmcintosh @spinnakerbot @ovidiupopa07