fix(amazon): Fix SpEL support for load balancers #7151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanmquach
requested review from
anotherchrisberry,
erikmunson and
christopherthielen
alanmquach
commented
Jun 26, 2019
| @@ -474,10 +474,10 @@ export class AwsServerGroupConfigurationService { | |||
| const vpcLoadBalancers = this.getVpcLoadBalancerNames(command); | |||
| const allTargetGroups = this.getTargetGroupNames(command); | |||
|
|
|||
| if (currentLoadBalancers && command.loadBalancers && !currentLoadBalancers.includes('${')) { | |||
There was a problem hiding this comment.
!currentLoadBalancers.includes('${') was always true because currentLoadBalancers, an array, almost never includes '${' as an item. Probably should've been something like !currentLoadBalancers.some(lb => lb.includes('${')) but I don't think we want that now either.
anotherchrisberry
approved these changes
Jun 26, 2019
anotherchrisberry
added a commit
that referenced
this pull request
Jun 27, 2019
* chore(core): Bump version to 0.0.378 058007e fix(core): properly update execution permalink on location change (#7152) 9bd9624 fix(projects): Fixed project dashboard to application link (#7154) d6ad8c2 feat(appengine): Enable new artifacts for config artifacts in deploy SG (#7153) a9a927b feat(appengine): Enable new artifacts workflow in deploy SG (#7147) * chore(amazon): Bump version to 0.0.195 8ee7e11 fix(amazon): Fix SpEL support for load balancers (#7151)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like we were actually 99% of the way there for supporting SpEL load balancers.
The only thing we were missing was to append the expression'ed load balancers into the list of valid options so that they don't get filtered out when we run
_.intersectionto filter out invalid load balancers.