fix(core): properly update execution permalink on location change #7152
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the
$stateChangeSuccess
event fires before the browser's location has been updated, so we're always behind a cycle when rendering the permalinks for executions.Moved into a separate component because
<Execution>
is already pretty pretty big.EDIT: I added a second commit to cut down on the re-render calls. What we are doing currently is kind of nuts and unnecessary and results in ~8 calls to
render
for each displayed execution every time a user clicks on a stage to toggle details or switch to a different execution.