Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(google): support stateful MIG operations #7196

Merged
merged 8 commits into from
Jul 9, 2019
Merged

feat(google): support stateful MIG operations #7196

merged 8 commits into from
Jul 9, 2019

Conversation

maggieneterval
Copy link
Contributor

@maggieneterval maggieneterval commented Jul 8, 2019 •
edited
Loading

  • Adds feature.gceStatefulMigsEnabled flag so alpha stateful MIG operations are hidden by default.
  • Converts server group disk descriptions components to React, moves all disk data-massaging logic out of controller into relevant component.
  • Makes minor UI adjustments to separate multiple disks of same image into own rows, and label boot disk as such.
  • Adds "Mark Disk Stateful" button to non-boot disks (and adds "Marked Stateful" label if already marked stateful).
  • Adds "Statefully Update" button to boot disks, allowing a new boot image to be entered. A future PR will add an image selection component so users do not need to manually type in the image name, and remove the unnecessary left sidebar from the image selection modal (I think a hide-nav prop was added in a pending PR).

7e2331b8-6dac-4ca8-8191-78bfcb923af5

@maggieneterval maggieneterval added the Do Not Merge Don't merge yet label Jul 8, 2019
@maggieneterval
Copy link
Contributor Author

cc @plumpy 🐕 🐶 😸

louisjimenez
louisjimenez approved these changes Jul 8, 2019
View reviewed changes
Copy link
Contributor

@louisjimenez louisjimenez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff 💯

plumpy
plumpy approved these changes Jul 9, 2019
View reviewed changes
Copy link
Member

@plumpy plumpy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💾🎉

@maggieneterval maggieneterval merged commit f340b02 into spinnaker:master Jul 9, 2019
@maggieneterval maggieneterval deleted the stateful-migs branch July 9, 2019 18:41
@anotherchrisberry anotherchrisberry mentioned this pull request Jul 9, 2019
Merged
anotherchrisberry added a commit that referenced this pull request Jul 9, 2019
@anotherchrisberry
Bump package core to 0.0.390 and amazon to 0.0.202 and titus to 0.0.1…
fba3c4a 
…04 (#7207)

* chore(core): Bump version to 0.0.390

768c210 fix(executions): Correctly populate trigger when rerunning an execution (#7205)
f340b02 feat(google): support stateful MIG operations (#7196)

* chore(amazon): Bump version to 0.0.202

bf68118 refactor(amazon): allow custom CLB config when ejecting from a wizard (#7206)

* chore(titus): Bump version to 0.0.104

a468de4 fix(spel): Fix exceptions when account is an expression (#7168)
@maggieneterval maggieneterval removed the Do Not Merge Don't merge yet label Jul 10, 2019
@christopherthielen christopherthielen mentioned this pull request Jul 15, 2019
Merged
christopherthielen added a commit to christopherthielen/deck that referenced this pull request Jul 15, 2019
@christopherthielen
chore(google): Bump version to 0.0.8
d8104eb 
ad483a0 fix(google): replace stateful MIG image input with dropdown (spinnaker#7210)
97db30b perf(google): improve performance of GCE image selection (spinnaker#7208)
f340b02 feat(google): support stateful MIG operations (spinnaker#7196)
ecb2dd1 feat(gce): Support new artifact model for deploy SG (spinnaker#7178)
christopherthielen added a commit that referenced this pull request Jul 15, 2019
@christopherthielen
chore(google): Bump version to 0.0.8
026d165 
ad483a0 fix(google): replace stateful MIG image input with dropdown (#7210)
97db30b perf(google): improve performance of GCE image selection (#7208)
f340b02 feat(google): support stateful MIG operations (#7196)
ecb2dd1 feat(gce): Support new artifact model for deploy SG (#7178)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louisjimenez louisjimenez louisjimenez approved these changes

@plumpy plumpy plumpy approved these changes

Assignees
No one assigned
Labels
target-release/1.15
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maggieneterval @plumpy @louisjimenez @spinnakerbot