fix(artifacts): fix uncaught undefined exception with artifacts #7362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jammy-Louie
commented
Aug 27, 2019
Jammy-Louie
commented
- fixes timing issue between Angular & React where there is a race condition when both the triggers and expected artifacts are updated at the same time.
- fix previously uncaught exception when expected artifacts is undefined
app/scripts/modules/core/src/pipeline/config/triggers/Trigger.tsx
Outdated
Show resolved
Hide resolved
Jammy-Louie
force-pushed
the
fix-new-artifact-issue
branch
from
6135732
to
1b9755f
Compare
maggieneterval
approved these changes
Aug 29, 2019
alanmquach
added a commit
to alanmquach/deck
that referenced
this pull request
Sep 3, 2019
6a47557 refactor(core): Reactify rename pipeline modal (spinnaker#7368) 0d88644 feat(notifications): Add additional fields for Github and get config from halyard (spinnaker#7239) 902c0b3 refactor(core): use a fieldLayout for manualExecution (spinnaker#7356) 9f5a860 fix(core/pipeline): fix date picker for manual execution parameters where constraint == 'date' 744cf19 feat(core/presentation): Add DayPickerInput form input component 5a354b1 feat(core): improve readability of pipeline cancellation message (spinnaker#7369) b889857 fix(artifacts): fix uncaught undefined exception with artifacts (spinnaker#7362) dc16166 fix(core): Fix shadowed var usage (spinnaker#7367) 5d1facd refactor(core): Reactify lock and unlock pipeline modal (spinnaker#7366) d131e01 fix(core): separate multiple task errors by newline (spinnaker#7355) 450d681 refactor(core): Reactify enable pipeline modal (spinnaker#7360) 5155ba1 refactor(core): Reactify disable pipeline modal (spinnaker#7358) 14035ae fix(kustomize): fix artifact selector (spinnaker#7359) 12f2eaa refactor(core): Reactify delete pipeline modal (spinnaker#7357) 48b7195 fix(kubernetes): add StageFailureMessage to Bake Manifest execution details (spinnaker#7354) 5fae6ef feat(core): add stage status precondition type (spinnaker#7348) f42977f fix(core): pipeline execution was not displaying all resolvedArtifacts (spinnaker#7353) 251250b fix(artifacts/k8s): fix rewrite k8s artifact edit (spinnaker#7352)
alanmquach
added a commit
that referenced
this pull request
Sep 3, 2019
* chore(core): Bump version to 0.0.405 6a47557 refactor(core): Reactify rename pipeline modal (#7368) 0d88644 feat(notifications): Add additional fields for Github and get config from halyard (#7239) 902c0b3 refactor(core): use a fieldLayout for manualExecution (#7356) 9f5a860 fix(core/pipeline): fix date picker for manual execution parameters where constraint == 'date' 744cf19 feat(core/presentation): Add DayPickerInput form input component 5a354b1 feat(core): improve readability of pipeline cancellation message (#7369) b889857 fix(artifacts): fix uncaught undefined exception with artifacts (#7362) dc16166 fix(core): Fix shadowed var usage (#7367) 5d1facd refactor(core): Reactify lock and unlock pipeline modal (#7366) d131e01 fix(core): separate multiple task errors by newline (#7355) 450d681 refactor(core): Reactify enable pipeline modal (#7360) 5155ba1 refactor(core): Reactify disable pipeline modal (#7358) 14035ae fix(kustomize): fix artifact selector (#7359) 12f2eaa refactor(core): Reactify delete pipeline modal (#7357) 48b7195 fix(kubernetes): add StageFailureMessage to Bake Manifest execution details (#7354) 5fae6ef feat(core): add stage status precondition type (#7348) f42977f fix(core): pipeline execution was not displaying all resolvedArtifacts (#7353) 251250b fix(artifacts/k8s): fix rewrite k8s artifact edit (#7352) * chore(titus): Bump version to 0.0.109 373f581 fix(titus): Removing NLB as it is not compatible with Titus (#7317) f0d3254 refactor(titus): Making service job processes human friendly (#7350)
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
…naker#7362) * fix(artifacts): fix uncaught undefined exception with artifacts * remove the usage of promises
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
* chore(core): Bump version to 0.0.405 6a47557 refactor(core): Reactify rename pipeline modal (spinnaker#7368) 0d88644 feat(notifications): Add additional fields for Github and get config from halyard (spinnaker#7239) 902c0b3 refactor(core): use a fieldLayout for manualExecution (spinnaker#7356) 9f5a860 fix(core/pipeline): fix date picker for manual execution parameters where constraint == 'date' 744cf19 feat(core/presentation): Add DayPickerInput form input component 5a354b1 feat(core): improve readability of pipeline cancellation message (spinnaker#7369) b889857 fix(artifacts): fix uncaught undefined exception with artifacts (spinnaker#7362) dc16166 fix(core): Fix shadowed var usage (spinnaker#7367) 5d1facd refactor(core): Reactify lock and unlock pipeline modal (spinnaker#7366) d131e01 fix(core): separate multiple task errors by newline (spinnaker#7355) 450d681 refactor(core): Reactify enable pipeline modal (spinnaker#7360) 5155ba1 refactor(core): Reactify disable pipeline modal (spinnaker#7358) 14035ae fix(kustomize): fix artifact selector (spinnaker#7359) 12f2eaa refactor(core): Reactify delete pipeline modal (spinnaker#7357) 48b7195 fix(kubernetes): add StageFailureMessage to Bake Manifest execution details (spinnaker#7354) 5fae6ef feat(core): add stage status precondition type (spinnaker#7348) f42977f fix(core): pipeline execution was not displaying all resolvedArtifacts (spinnaker#7353) 251250b fix(artifacts/k8s): fix rewrite k8s artifact edit (spinnaker#7352) * chore(titus): Bump version to 0.0.109 373f581 fix(titus): Removing NLB as it is not compatible with Titus (spinnaker#7317) f0d3254 refactor(titus): Making service job processes human friendly (spinnaker#7350)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.