Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(artifacts/bitbucket): Update the help key to the correct reference #7475

Merged
merged 2 commits into from
Oct 2, 2019

Conversation

battlecow
Copy link
Contributor

Fixes the help text to use the correct reference.

@maggieneterval maggieneterval self-requested a review October 2, 2019 13:14
Copy link
Contributor

@maggieneterval maggieneterval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thanks so much @battlecow! 🎉 🎉

@maggieneterval maggieneterval merged commit f121b71 into spinnaker:master Oct 2, 2019
Jammy-Louie pushed a commit to pivotal/deck that referenced this pull request Oct 2, 2019
@battlecow
Copy link
Contributor Author

@spinnakerbot cherry-pick 1.16

spinnakerbot pushed a commit that referenced this pull request Oct 3, 2019
@spinnakerbot
Copy link
Contributor

Cherry pick successful: #7482

louisjimenez pushed a commit that referenced this pull request Oct 3, 2019
erikmunson pushed a commit to erikmunson/deck that referenced this pull request Oct 4, 2019
a5f192e feat(core/presentation): Add helper functions for generating categorized validation messages (spinnaker#7488)
7d91de6 fix(pipeline): triggers were not reverting in the ui (spinnaker#7485)
5c3fcc7 refactor(core/help): Migrate HelpContext to react hooks style (spinnaker#7487)
3c08b38 feat(core/presentation): Migrate ValidationMessage to new CSS styles (spinnaker#7481)
523c6bb fix(triggers): fix a few minor issues with manual execution triggers (spinnaker#7484)
0d0caa9 fix(monitored deploy): properly initialize defaults (spinnaker#7473)
dc2a74b feat(core/presentation): Put margin between StandardFieldLayout's input and validation (spinnaker#7476)
6cd7e9d refactor(pipeline): Reactify the copy stage modal (spinnaker#7453)
5867de1 feat(precondition): add custom message to precondition (spinnaker#7448)
f121b71 fix(artifacts/bitbucket): Update the help key to the correct reference to bitbucket (spinnaker#7475)
ee18eb0 fix(core/serverGroup): Correct 'simple scaling' heuristic (spinnaker#7385)
30c7f2c fix(core/utils): Support traversing keys which contain dots in them using array notation (spinnaker#7471)
f2790a7 feat(core/presentation): Begin adding support for error categories in validation API (spinnaker#7467)
erikmunson pushed a commit that referenced this pull request Oct 4, 2019
a5f192e feat(core/presentation): Add helper functions for generating categorized validation messages (#7488)
7d91de6 fix(pipeline): triggers were not reverting in the ui (#7485)
5c3fcc7 refactor(core/help): Migrate HelpContext to react hooks style (#7487)
3c08b38 feat(core/presentation): Migrate ValidationMessage to new CSS styles (#7481)
523c6bb fix(triggers): fix a few minor issues with manual execution triggers (#7484)
0d0caa9 fix(monitored deploy): properly initialize defaults (#7473)
dc2a74b feat(core/presentation): Put margin between StandardFieldLayout's input and validation (#7476)
6cd7e9d refactor(pipeline): Reactify the copy stage modal (#7453)
5867de1 feat(precondition): add custom message to precondition (#7448)
f121b71 fix(artifacts/bitbucket): Update the help key to the correct reference to bitbucket (#7475)
ee18eb0 fix(core/serverGroup): Correct 'simple scaling' heuristic (#7385)
30c7f2c fix(core/utils): Support traversing keys which contain dots in them using array notation (#7471)
f2790a7 feat(core/presentation): Begin adding support for error categories in validation API (#7467)
yunzhangit pushed a commit to yunzhangit/deck that referenced this pull request Mar 28, 2021
yunzhangit pushed a commit to yunzhangit/deck that referenced this pull request Mar 28, 2021
a5f192e feat(core/presentation): Add helper functions for generating categorized validation messages (spinnaker#7488)
7d91de6 fix(pipeline): triggers were not reverting in the ui (spinnaker#7485)
5c3fcc7 refactor(core/help): Migrate HelpContext to react hooks style (spinnaker#7487)
3c08b38 feat(core/presentation): Migrate ValidationMessage to new CSS styles (spinnaker#7481)
523c6bb fix(triggers): fix a few minor issues with manual execution triggers (spinnaker#7484)
0d0caa9 fix(monitored deploy): properly initialize defaults (spinnaker#7473)
dc2a74b feat(core/presentation): Put margin between StandardFieldLayout's input and validation (spinnaker#7476)
6cd7e9d refactor(pipeline): Reactify the copy stage modal (spinnaker#7453)
5867de1 feat(precondition): add custom message to precondition (spinnaker#7448)
f121b71 fix(artifacts/bitbucket): Update the help key to the correct reference to bitbucket (spinnaker#7475)
ee18eb0 fix(core/serverGroup): Correct 'simple scaling' heuristic (spinnaker#7385)
30c7f2c fix(core/utils): Support traversing keys which contain dots in them using array notation (spinnaker#7471)
f2790a7 feat(core/presentation): Begin adding support for error categories in validation API (spinnaker#7467)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants