fix(core/serverGroup): Correct 'simple scaling' heuristic #7385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was seemingly introduced from 6630f9b The regression is that the "Capacity" section always considers the scaling mode to be "simple", and doesn't show the actual min/max capacity numbers, only Desired. Noticed using an AWS account.
|
I built this branch into an artifact and gave it to Halyard. Looks good from here:
@spinnaker/reviewers |
|
@spinnakerbot add-label provider/aws |
|
Sorry! "provider/aws" is not a label yet, and I don't create labels to avoid spam. |
|
@christopherthielen PTAL |
kevinawoo
approved these changes
Oct 2, 2019
Jammy-Louie
pushed a commit
to pivotal/deck
that referenced
this pull request
Oct 2, 2019
…7385) * fix(core/serverGroup): Correct 'simple scaling' heuristic This was seemingly introduced from 6630f9b The regression is that the "Capacity" section always considers the scaling mode to be "simple", and doesn't show the actual min/max capacity numbers, only Desired. Noticed using an AWS account. * fix(core/serverGroup): Adding test for capacity details
erikmunson
pushed a commit
to erikmunson/deck
that referenced
this pull request
Oct 4, 2019
a5f192e feat(core/presentation): Add helper functions for generating categorized validation messages (spinnaker#7488) 7d91de6 fix(pipeline): triggers were not reverting in the ui (spinnaker#7485) 5c3fcc7 refactor(core/help): Migrate HelpContext to react hooks style (spinnaker#7487) 3c08b38 feat(core/presentation): Migrate ValidationMessage to new CSS styles (spinnaker#7481) 523c6bb fix(triggers): fix a few minor issues with manual execution triggers (spinnaker#7484) 0d0caa9 fix(monitored deploy): properly initialize defaults (spinnaker#7473) dc2a74b feat(core/presentation): Put margin between StandardFieldLayout's input and validation (spinnaker#7476) 6cd7e9d refactor(pipeline): Reactify the copy stage modal (spinnaker#7453) 5867de1 feat(precondition): add custom message to precondition (spinnaker#7448) f121b71 fix(artifacts/bitbucket): Update the help key to the correct reference to bitbucket (spinnaker#7475) ee18eb0 fix(core/serverGroup): Correct 'simple scaling' heuristic (spinnaker#7385) 30c7f2c fix(core/utils): Support traversing keys which contain dots in them using array notation (spinnaker#7471) f2790a7 feat(core/presentation): Begin adding support for error categories in validation API (spinnaker#7467)
erikmunson
pushed a commit
that referenced
this pull request
Oct 4, 2019
a5f192e feat(core/presentation): Add helper functions for generating categorized validation messages (#7488) 7d91de6 fix(pipeline): triggers were not reverting in the ui (#7485) 5c3fcc7 refactor(core/help): Migrate HelpContext to react hooks style (#7487) 3c08b38 feat(core/presentation): Migrate ValidationMessage to new CSS styles (#7481) 523c6bb fix(triggers): fix a few minor issues with manual execution triggers (#7484) 0d0caa9 fix(monitored deploy): properly initialize defaults (#7473) dc2a74b feat(core/presentation): Put margin between StandardFieldLayout's input and validation (#7476) 6cd7e9d refactor(pipeline): Reactify the copy stage modal (#7453) 5867de1 feat(precondition): add custom message to precondition (#7448) f121b71 fix(artifacts/bitbucket): Update the help key to the correct reference to bitbucket (#7475) ee18eb0 fix(core/serverGroup): Correct 'simple scaling' heuristic (#7385) 30c7f2c fix(core/utils): Support traversing keys which contain dots in them using array notation (#7471) f2790a7 feat(core/presentation): Begin adding support for error categories in validation API (#7467)
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
…7385) * fix(core/serverGroup): Correct 'simple scaling' heuristic This was seemingly introduced from 6630f9b The regression is that the "Capacity" section always considers the scaling mode to be "simple", and doesn't show the actual min/max capacity numbers, only Desired. Noticed using an AWS account. * fix(core/serverGroup): Adding test for capacity details
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
a5f192e feat(core/presentation): Add helper functions for generating categorized validation messages (spinnaker#7488) 7d91de6 fix(pipeline): triggers were not reverting in the ui (spinnaker#7485) 5c3fcc7 refactor(core/help): Migrate HelpContext to react hooks style (spinnaker#7487) 3c08b38 feat(core/presentation): Migrate ValidationMessage to new CSS styles (spinnaker#7481) 523c6bb fix(triggers): fix a few minor issues with manual execution triggers (spinnaker#7484) 0d0caa9 fix(monitored deploy): properly initialize defaults (spinnaker#7473) dc2a74b feat(core/presentation): Put margin between StandardFieldLayout's input and validation (spinnaker#7476) 6cd7e9d refactor(pipeline): Reactify the copy stage modal (spinnaker#7453) 5867de1 feat(precondition): add custom message to precondition (spinnaker#7448) f121b71 fix(artifacts/bitbucket): Update the help key to the correct reference to bitbucket (spinnaker#7475) ee18eb0 fix(core/serverGroup): Correct 'simple scaling' heuristic (spinnaker#7385) 30c7f2c fix(core/utils): Support traversing keys which contain dots in them using array notation (spinnaker#7471) f2790a7 feat(core/presentation): Begin adding support for error categories in validation API (spinnaker#7467)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was seemingly introduced from 6630f9b ( original aws-specific line, new generalized line )
The regression is that the "Capacity" section always considers the scaling mode to be "simple", and doesn't show the actual min/max capacity numbers, only Desired. Selecting the "Resize Server Group" function still displays correct numbers in its dialog, as shown below.
Noticed using an AWS account.