feat(precondition): add custom message to precondition #7448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gal-yardeni
force-pushed
the
custom-message-precondition
branch
from
e4f042e
to
b4e8dd2
Compare
|
FYI @luispollo |
...cripts/modules/core/src/pipeline/config/preconditions/types/expression/additionalFields.html
Outdated
Show resolved
Hide resolved
|
one note, otherwise looks good |
erikmunson
reviewed
Sep 27, 2019
...es/core/src/pipeline/config/stages/checkPreconditions/CheckPreconditionsExecutionDetails.tsx
Outdated
Show resolved
Hide resolved
...es/core/src/pipeline/config/stages/checkPreconditions/CheckPreconditionsExecutionDetails.tsx
Outdated
Show resolved
Hide resolved
...cripts/modules/core/src/pipeline/config/preconditions/types/expression/additionalFields.html
Outdated
Show resolved
Hide resolved
gal-yardeni
force-pushed
the
custom-message-precondition
branch
from
7366052
to
8423656
Compare
|
Addressed your comments - @erikmunson , @marchello2000 |
erikmunson
approved these changes
Oct 2, 2019
erikmunson
pushed a commit
to erikmunson/deck
that referenced
this pull request
Oct 4, 2019
a5f192e feat(core/presentation): Add helper functions for generating categorized validation messages (spinnaker#7488) 7d91de6 fix(pipeline): triggers were not reverting in the ui (spinnaker#7485) 5c3fcc7 refactor(core/help): Migrate HelpContext to react hooks style (spinnaker#7487) 3c08b38 feat(core/presentation): Migrate ValidationMessage to new CSS styles (spinnaker#7481) 523c6bb fix(triggers): fix a few minor issues with manual execution triggers (spinnaker#7484) 0d0caa9 fix(monitored deploy): properly initialize defaults (spinnaker#7473) dc2a74b feat(core/presentation): Put margin between StandardFieldLayout's input and validation (spinnaker#7476) 6cd7e9d refactor(pipeline): Reactify the copy stage modal (spinnaker#7453) 5867de1 feat(precondition): add custom message to precondition (spinnaker#7448) f121b71 fix(artifacts/bitbucket): Update the help key to the correct reference to bitbucket (spinnaker#7475) ee18eb0 fix(core/serverGroup): Correct 'simple scaling' heuristic (spinnaker#7385) 30c7f2c fix(core/utils): Support traversing keys which contain dots in them using array notation (spinnaker#7471) f2790a7 feat(core/presentation): Begin adding support for error categories in validation API (spinnaker#7467)
erikmunson
pushed a commit
that referenced
this pull request
Oct 4, 2019
a5f192e feat(core/presentation): Add helper functions for generating categorized validation messages (#7488) 7d91de6 fix(pipeline): triggers were not reverting in the ui (#7485) 5c3fcc7 refactor(core/help): Migrate HelpContext to react hooks style (#7487) 3c08b38 feat(core/presentation): Migrate ValidationMessage to new CSS styles (#7481) 523c6bb fix(triggers): fix a few minor issues with manual execution triggers (#7484) 0d0caa9 fix(monitored deploy): properly initialize defaults (#7473) dc2a74b feat(core/presentation): Put margin between StandardFieldLayout's input and validation (#7476) 6cd7e9d refactor(pipeline): Reactify the copy stage modal (#7453) 5867de1 feat(precondition): add custom message to precondition (#7448) f121b71 fix(artifacts/bitbucket): Update the help key to the correct reference to bitbucket (#7475) ee18eb0 fix(core/serverGroup): Correct 'simple scaling' heuristic (#7385) 30c7f2c fix(core/utils): Support traversing keys which contain dots in them using array notation (#7471) f2790a7 feat(core/presentation): Begin adding support for error categories in validation API (#7467)
This was referenced Nov 12, 2019
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
a5f192e feat(core/presentation): Add helper functions for generating categorized validation messages (spinnaker#7488) 7d91de6 fix(pipeline): triggers were not reverting in the ui (spinnaker#7485) 5c3fcc7 refactor(core/help): Migrate HelpContext to react hooks style (spinnaker#7487) 3c08b38 feat(core/presentation): Migrate ValidationMessage to new CSS styles (spinnaker#7481) 523c6bb fix(triggers): fix a few minor issues with manual execution triggers (spinnaker#7484) 0d0caa9 fix(monitored deploy): properly initialize defaults (spinnaker#7473) dc2a74b feat(core/presentation): Put margin between StandardFieldLayout's input and validation (spinnaker#7476) 6cd7e9d refactor(pipeline): Reactify the copy stage modal (spinnaker#7453) 5867de1 feat(precondition): add custom message to precondition (spinnaker#7448) f121b71 fix(artifacts/bitbucket): Update the help key to the correct reference to bitbucket (spinnaker#7475) ee18eb0 fix(core/serverGroup): Correct 'simple scaling' heuristic (spinnaker#7385) 30c7f2c fix(core/utils): Support traversing keys which contain dots in them using array notation (spinnaker#7471) f2790a7 feat(core/presentation): Begin adding support for error categories in validation API (spinnaker#7467)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a user description field when providing precondition expression. In case of failure, instead of showing a generic error message such as "'No reason provided", the user custom description will be shown.