feat(core/jenkins): Refer to Jenkins controller instead of master #7531
Conversation
|
The following commits need their title changed:
Please format your commit title into the form:
This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here. |
| @@ -34,11 +34,13 @@ export function BaseBuildTrigger(buildTriggerProps: IBaseBuildTriggerConfigProps | |||
| } | |||
| }, [fetchJobs.result]); | |||
|
|
|||
| const label = buildTriggerType === 'jenkins' ? 'Controller' : 'Master'; | |||
There was a problem hiding this comment.
I wonder if we can also change the term for other trigger types; either using 'Controller' for all trigger types, or perhaps using something like 'Build Service'? If I understand correctly, this term was only ever used for Jenkins so we can probably change other services at the same time.
There was a problem hiding this comment.
+1 can we check what terminology the other build systems use?
There was a problem hiding this comment.
Sure, I will look into this and circle back with you both. Right now, Jenkins, Travis and Wercker use this component and were all referring to "master".
There was a problem hiding this comment.
@ezimanyi @christopherthielen I don't see any strong ties to Controller terminology with these other trigger types. I find Build Service more intuitive for Travis, Concourse, and Wercker since they are not tied to the Controller terminology. What do you think?
There was a problem hiding this comment.
I like "Build Service"; that's what I used on the back-end when I was doing some refactoring of Igor and wanted to improve the terminology so this will match the back-end.
There was a problem hiding this comment.
Ok I will update the remaining triggers, but leave Jenkins as Controller
caseyhebebrand
force-pushed
the
jenkins-controller
branch
from
e8833c5
to
b327153
Compare
f57c70b feat(core): alphabetize applications in project config dropdown (spinnaker#7549) 78cbe15 feat(core/jenkins): Refer to Jenkins controller instead of master (spinnaker#7531) 8c0d087 feat(core/presentation): add revalidate api to IFormInputValidation - Make all fields on IFormInputValidation non-optional b384038 feat(core/presentation): Add useDebouncedValue react hook renamed hooks files to '.hook.ts' and exported all from an index.ts 17be6af feat(kubernetes): support rolling restart operation for deployments (spinnaker#7538) 7e8cb7e fix(monitored deploy): fix the rollback config to match what orca expects (spinnaker#7532)
* chore(core): Bump version to 0.0.425 f57c70b feat(core): alphabetize applications in project config dropdown (#7549) 78cbe15 feat(core/jenkins): Refer to Jenkins controller instead of master (#7531) 8c0d087 feat(core/presentation): add revalidate api to IFormInputValidation - Make all fields on IFormInputValidation non-optional b384038 feat(core/presentation): Add useDebouncedValue react hook renamed hooks files to '.hook.ts' and exported all from an index.ts 17be6af feat(kubernetes): support rolling restart operation for deployments (#7538) 7e8cb7e fix(monitored deploy): fix the rollback config to match what orca expects (#7532) * chore(amazon): Bump version to 0.0.218 938d219 feat(provider/aws): Show load balancer warning based on settings (#7542) 828f7e7 fix(awslb): Preventing edits against orphaned load balancers (#7547) 6186e40 refactor(aws): move Resize item in the AmazonServerGroupAction dropdown into separate component
…innaker#7531) * Update jenkins master to controller * Update terminaology for remaining triggers * Update wercker stage
* chore(core): Bump version to 0.0.425 f57c70b feat(core): alphabetize applications in project config dropdown (spinnaker#7549) 78cbe15 feat(core/jenkins): Refer to Jenkins controller instead of master (spinnaker#7531) 8c0d087 feat(core/presentation): add revalidate api to IFormInputValidation - Make all fields on IFormInputValidation non-optional b384038 feat(core/presentation): Add useDebouncedValue react hook renamed hooks files to '.hook.ts' and exported all from an index.ts 17be6af feat(kubernetes): support rolling restart operation for deployments (spinnaker#7538) 7e8cb7e fix(monitored deploy): fix the rollback config to match what orca expects (spinnaker#7532) * chore(amazon): Bump version to 0.0.218 938d219 feat(provider/aws): Show load balancer warning based on settings (spinnaker#7542) 828f7e7 fix(awslb): Preventing edits against orphaned load balancers (spinnaker#7547) 6186e40 refactor(aws): move Resize item in the AmazonServerGroupAction dropdown into separate component
Currently we reference the Jenkins controller as 'master' in the config for both a Jenkins stage and trigger. This terminology has been deprecated by Jenkins and we need to reference the updated terminology of 'controller'.