fix(monitored deploy): fix the rollback config to match what orca expects #7532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ects Note: `Manual` type is not yet implemented in orca, hence it's not used in deck, other then the enum definition
alanmquach
approved these changes
Oct 16, 2019
| disabled={!rollbackOnFailure} | ||
| onChange={this.destroyFailedAsgChange} | ||
| /> | ||
| Destroy the failed server group after rollback <HelpField id="strategy.monitored.destroyFailedAsg" /> |
There was a problem hiding this comment.
Didn't you want to grey this out?
There was a problem hiding this comment.
yes... but it was too hard :)
caseyhebebrand
added a commit
to caseyhebebrand/deck
that referenced
this pull request
Oct 23, 2019
f57c70b feat(core): alphabetize applications in project config dropdown (spinnaker#7549) 78cbe15 feat(core/jenkins): Refer to Jenkins controller instead of master (spinnaker#7531) 8c0d087 feat(core/presentation): add revalidate api to IFormInputValidation - Make all fields on IFormInputValidation non-optional b384038 feat(core/presentation): Add useDebouncedValue react hook renamed hooks files to '.hook.ts' and exported all from an index.ts 17be6af feat(kubernetes): support rolling restart operation for deployments (spinnaker#7538) 7e8cb7e fix(monitored deploy): fix the rollback config to match what orca expects (spinnaker#7532)
mergify bot
pushed a commit
that referenced
this pull request
Oct 23, 2019
* chore(core): Bump version to 0.0.425 f57c70b feat(core): alphabetize applications in project config dropdown (#7549) 78cbe15 feat(core/jenkins): Refer to Jenkins controller instead of master (#7531) 8c0d087 feat(core/presentation): add revalidate api to IFormInputValidation - Make all fields on IFormInputValidation non-optional b384038 feat(core/presentation): Add useDebouncedValue react hook renamed hooks files to '.hook.ts' and exported all from an index.ts 17be6af feat(kubernetes): support rolling restart operation for deployments (#7538) 7e8cb7e fix(monitored deploy): fix the rollback config to match what orca expects (#7532) * chore(amazon): Bump version to 0.0.218 938d219 feat(provider/aws): Show load balancer warning based on settings (#7542) 828f7e7 fix(awslb): Preventing edits against orphaned load balancers (#7547) 6186e40 refactor(aws): move Resize item in the AmazonServerGroupAction dropdown into separate component
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
…ects (spinnaker#7532) Note: `Manual` type is not yet implemented in orca, hence it's not used in deck, other then the enum definition
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
* chore(core): Bump version to 0.0.425 f57c70b feat(core): alphabetize applications in project config dropdown (spinnaker#7549) 78cbe15 feat(core/jenkins): Refer to Jenkins controller instead of master (spinnaker#7531) 8c0d087 feat(core/presentation): add revalidate api to IFormInputValidation - Make all fields on IFormInputValidation non-optional b384038 feat(core/presentation): Add useDebouncedValue react hook renamed hooks files to '.hook.ts' and exported all from an index.ts 17be6af feat(kubernetes): support rolling restart operation for deployments (spinnaker#7538) 7e8cb7e fix(monitored deploy): fix the rollback config to match what orca expects (spinnaker#7532) * chore(amazon): Bump version to 0.0.218 938d219 feat(provider/aws): Show load balancer warning based on settings (spinnaker#7542) 828f7e7 fix(awslb): Preventing edits against orphaned load balancers (spinnaker#7547) 6186e40 refactor(aws): move Resize item in the AmazonServerGroupAction dropdown into separate component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note:
Manualtype is not yet implemented in orca, hence it's not used in deck, other then the enum definition