feat(core/managed): visually refresh/rebrand infra details indicator #7617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikmunson
requested review from
asher,
robfletcher,
luispollo,
emjburns,
gal-yardeni,
christopherthielen and
caseyhebebrand
erikmunson
changed the title
erikmunson
commented
Nov 8, 2019
|
|
||
| .ManagedResourceDetailsIndicator .summary-message { | ||
| font-size: 12px; | ||
| font-weight: 300; |
There was a problem hiding this comment.
@gcomstock I made the judgement call to drop this down to 300 because it felt like the text was throwing off the balance of the button/logo a bit — more than happy to go back on that if you prefer it at a normal weight or are worried about contrast (also only have a high-DPI display to judge with). Here's what normal weight looks like for comparison with the images in the PR description:
There was a problem hiding this comment.
Good call. This banner fits the space well.
|
Looks good! Thanks |
|
LGTM |
caseyhebebrand
approved these changes
Nov 9, 2019
erikmunson
pushed a commit
to erikmunson/deck
that referenced
this pull request
Nov 11, 2019
fc054fe feat(core/managed): visually refresh/rebrand infra details indicator (spinnaker#7617) 9c8ac86 fix(core/managed): properly diff/patch mutable infra groupings (spinnaker#7618) ae91048 feat(core/presentation): Create a SpelInput that supports server-side preview of spel expressions (against previous executions) 55beff7 feat(core/spel): Add a SpelService to (initially) evaluate expressions on the Server b01e6db refactor(core/presentation): use useInternalValidator in NumberInput 49f880f feat(core/presentation): Create a useInternalValidator hook for FormInputs to use e370d47 feat(core/presentation): Made useData hook default result behavior more reasonable (spinnaker#7602) 9d99e04 feat(core/managed): add RESUMED resource status (spinnaker#7611) f49fedf feat(core/managed): add deep links to status reference doc (spinnaker#7610) 9abd35f fix(core/presentation): Handle 'null' in orEmptyString helper (spinnaker#7606) e0cc0d6 feat(core/presentation): Mark all SpinFormik initialValues fields as 'touched' (spinnaker#7604) 431cb86 feat(core/presentation): Add generic type param (for selected data type) to ReactSelectInput (spinnaker#7603) e6280e5 fix(core/presentation): MapEditor: Make errors fill the entire row width. 3df215b fix(core/presentation): FormikFormField: call revalidate whenever internal validators change ae396e5 fix(core/presentation): pass objects through in useValidationData There's a weird case where a FormikFormField may be used for a complex object with multiple fields and/or arrays. In this case, the Field's validator should return a structured error object. This isn't fully accounted for in the FormField API. For now, pass the complex error object through as 'validationMessage'. Tag it as "hidden" so we don't try to render it elsewhere as a ReactNode. ef35c5c fix(artifacts): enable inline editing of base64 artifacts (spinnaker#7612) 97a033f chore(core/presentation): rename test file to FormValidator.spec.ts d343512 fix(core/application): add error state to application models, log exceptions (spinnaker#7599) 236e623 fix(core/presentation): remove style + wrapperClassName from HoverablePopover (spinnaker#7597) 7a81a66 feat(script): expose propertiesFile field (spinnaker#7595)
erikmunson
pushed a commit
that referenced
this pull request
Nov 11, 2019
* chore(core): Bump version to 0.0.430 fc054fe feat(core/managed): visually refresh/rebrand infra details indicator (#7617) 9c8ac86 fix(core/managed): properly diff/patch mutable infra groupings (#7618) ae91048 feat(core/presentation): Create a SpelInput that supports server-side preview of spel expressions (against previous executions) 55beff7 feat(core/spel): Add a SpelService to (initially) evaluate expressions on the Server b01e6db refactor(core/presentation): use useInternalValidator in NumberInput 49f880f feat(core/presentation): Create a useInternalValidator hook for FormInputs to use e370d47 feat(core/presentation): Made useData hook default result behavior more reasonable (#7602) 9d99e04 feat(core/managed): add RESUMED resource status (#7611) f49fedf feat(core/managed): add deep links to status reference doc (#7610) 9abd35f fix(core/presentation): Handle 'null' in orEmptyString helper (#7606) e0cc0d6 feat(core/presentation): Mark all SpinFormik initialValues fields as 'touched' (#7604) 431cb86 feat(core/presentation): Add generic type param (for selected data type) to ReactSelectInput (#7603) e6280e5 fix(core/presentation): MapEditor: Make errors fill the entire row width. 3df215b fix(core/presentation): FormikFormField: call revalidate whenever internal validators change ae396e5 fix(core/presentation): pass objects through in useValidationData There's a weird case where a FormikFormField may be used for a complex object with multiple fields and/or arrays. In this case, the Field's validator should return a structured error object. This isn't fully accounted for in the FormField API. For now, pass the complex error object through as 'validationMessage'. Tag it as "hidden" so we don't try to render it elsewhere as a ReactNode. ef35c5c fix(artifacts): enable inline editing of base64 artifacts (#7612) 97a033f chore(core/presentation): rename test file to FormValidator.spec.ts d343512 fix(core/application): add error state to application models, log exceptions (#7599) 236e623 fix(core/presentation): remove style + wrapperClassName from HoverablePopover (#7597) 7a81a66 feat(script): expose propertiesFile field (#7595) * chore(amazon): Bump version to 0.0.223 3e655b9 feat(amazon/instance): add configurable exclusion rules for families + categories (#7623)
6 tasks
sergiopena
pushed a commit
to sergiopena/deck
that referenced
this pull request
Jan 10, 2020
…pinnaker#7617) * feat(core/presentation): add flex-pull-left utility class * feat(core/managed): add full-color logo vector * feat(core/managed): visually refresh/rebrand infra details indicator
sergiopena
pushed a commit
to sergiopena/deck
that referenced
this pull request
Jan 10, 2020
* chore(core): Bump version to 0.0.430 fc054fe feat(core/managed): visually refresh/rebrand infra details indicator (spinnaker#7617) 9c8ac86 fix(core/managed): properly diff/patch mutable infra groupings (spinnaker#7618) ae91048 feat(core/presentation): Create a SpelInput that supports server-side preview of spel expressions (against previous executions) 55beff7 feat(core/spel): Add a SpelService to (initially) evaluate expressions on the Server b01e6db refactor(core/presentation): use useInternalValidator in NumberInput 49f880f feat(core/presentation): Create a useInternalValidator hook for FormInputs to use e370d47 feat(core/presentation): Made useData hook default result behavior more reasonable (spinnaker#7602) 9d99e04 feat(core/managed): add RESUMED resource status (spinnaker#7611) f49fedf feat(core/managed): add deep links to status reference doc (spinnaker#7610) 9abd35f fix(core/presentation): Handle 'null' in orEmptyString helper (spinnaker#7606) e0cc0d6 feat(core/presentation): Mark all SpinFormik initialValues fields as 'touched' (spinnaker#7604) 431cb86 feat(core/presentation): Add generic type param (for selected data type) to ReactSelectInput (spinnaker#7603) e6280e5 fix(core/presentation): MapEditor: Make errors fill the entire row width. 3df215b fix(core/presentation): FormikFormField: call revalidate whenever internal validators change ae396e5 fix(core/presentation): pass objects through in useValidationData There's a weird case where a FormikFormField may be used for a complex object with multiple fields and/or arrays. In this case, the Field's validator should return a structured error object. This isn't fully accounted for in the FormField API. For now, pass the complex error object through as 'validationMessage'. Tag it as "hidden" so we don't try to render it elsewhere as a ReactNode. ef35c5c fix(artifacts): enable inline editing of base64 artifacts (spinnaker#7612) 97a033f chore(core/presentation): rename test file to FormValidator.spec.ts d343512 fix(core/application): add error state to application models, log exceptions (spinnaker#7599) 236e623 fix(core/presentation): remove style + wrapperClassName from HoverablePopover (spinnaker#7597) 7a81a66 feat(script): expose propertiesFile field (spinnaker#7595) * chore(amazon): Bump version to 0.0.223 3e655b9 feat(amazon/instance): add configurable exclusion rules for families + categories (spinnaker#7623)
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
…pinnaker#7617) * feat(core/presentation): add flex-pull-left utility class * feat(core/managed): add full-color logo vector * feat(core/managed): visually refresh/rebrand infra details indicator
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
* chore(core): Bump version to 0.0.430 fc054fe feat(core/managed): visually refresh/rebrand infra details indicator (spinnaker#7617) 9c8ac86 fix(core/managed): properly diff/patch mutable infra groupings (spinnaker#7618) ae91048 feat(core/presentation): Create a SpelInput that supports server-side preview of spel expressions (against previous executions) 55beff7 feat(core/spel): Add a SpelService to (initially) evaluate expressions on the Server b01e6db refactor(core/presentation): use useInternalValidator in NumberInput 49f880f feat(core/presentation): Create a useInternalValidator hook for FormInputs to use e370d47 feat(core/presentation): Made useData hook default result behavior more reasonable (spinnaker#7602) 9d99e04 feat(core/managed): add RESUMED resource status (spinnaker#7611) f49fedf feat(core/managed): add deep links to status reference doc (spinnaker#7610) 9abd35f fix(core/presentation): Handle 'null' in orEmptyString helper (spinnaker#7606) e0cc0d6 feat(core/presentation): Mark all SpinFormik initialValues fields as 'touched' (spinnaker#7604) 431cb86 feat(core/presentation): Add generic type param (for selected data type) to ReactSelectInput (spinnaker#7603) e6280e5 fix(core/presentation): MapEditor: Make errors fill the entire row width. 3df215b fix(core/presentation): FormikFormField: call revalidate whenever internal validators change ae396e5 fix(core/presentation): pass objects through in useValidationData There's a weird case where a FormikFormField may be used for a complex object with multiple fields and/or arrays. In this case, the Field's validator should return a structured error object. This isn't fully accounted for in the FormField API. For now, pass the complex error object through as 'validationMessage'. Tag it as "hidden" so we don't try to render it elsewhere as a ReactNode. ef35c5c fix(artifacts): enable inline editing of base64 artifacts (spinnaker#7612) 97a033f chore(core/presentation): rename test file to FormValidator.spec.ts d343512 fix(core/application): add error state to application models, log exceptions (spinnaker#7599) 236e623 fix(core/presentation): remove style + wrapperClassName from HoverablePopover (spinnaker#7597) 7a81a66 feat(script): expose propertiesFile field (spinnaker#7595) * chore(amazon): Bump version to 0.0.223 3e655b9 feat(amazon/instance): add configurable exclusion rules for families + categories (spinnaker#7623)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a snazzy new set of branding and visual language, so let's use the crap out of it:
Before:
After:
Dropdown open:
Note this is a modded version of one of Greg's designs that was originally done in the context of a new UI view that doesn't exist. I've adapted the sizing, spacing, and the dropdown to fit the current UI while trying to keep the same visual feel.
(cc @gcomstock)