-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core/managed): add RESUMED resource status #7611
feat(core/managed): add RESUMED resource status #7611
Conversation
), | ||
}, | ||
RESUMED: { | ||
iconClass: 'icon-md', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gcomstock FYI, right now I'm just using the unadorned "M" icon because 1) I don't have an icon for this new "resumed" status 2) this status theoretically will only show up for a few seconds at a time, so unlikely to matter much.
If you have time, might be cool to get a dedicated icon (maybe like a play icon to compliment the pause one?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea! Here you are: #7613
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EPIC thanks for the fast follow up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
41ca9f5
to
75f1dce
Compare
75f1dce
to
5c6988c
Compare
app/scripts/modules/core/src/managed/ManagedResourceStatusIndicator.tsx
Outdated
Show resolved
Hide resolved
fc054fe feat(core/managed): visually refresh/rebrand infra details indicator (spinnaker#7617) 9c8ac86 fix(core/managed): properly diff/patch mutable infra groupings (spinnaker#7618) ae91048 feat(core/presentation): Create a SpelInput that supports server-side preview of spel expressions (against previous executions) 55beff7 feat(core/spel): Add a SpelService to (initially) evaluate expressions on the Server b01e6db refactor(core/presentation): use useInternalValidator in NumberInput 49f880f feat(core/presentation): Create a useInternalValidator hook for FormInputs to use e370d47 feat(core/presentation): Made useData hook default result behavior more reasonable (spinnaker#7602) 9d99e04 feat(core/managed): add RESUMED resource status (spinnaker#7611) f49fedf feat(core/managed): add deep links to status reference doc (spinnaker#7610) 9abd35f fix(core/presentation): Handle 'null' in orEmptyString helper (spinnaker#7606) e0cc0d6 feat(core/presentation): Mark all SpinFormik initialValues fields as 'touched' (spinnaker#7604) 431cb86 feat(core/presentation): Add generic type param (for selected data type) to ReactSelectInput (spinnaker#7603) e6280e5 fix(core/presentation): MapEditor: Make errors fill the entire row width. 3df215b fix(core/presentation): FormikFormField: call revalidate whenever internal validators change ae396e5 fix(core/presentation): pass objects through in useValidationData There's a weird case where a FormikFormField may be used for a complex object with multiple fields and/or arrays. In this case, the Field's validator should return a structured error object. This isn't fully accounted for in the FormField API. For now, pass the complex error object through as 'validationMessage'. Tag it as "hidden" so we don't try to render it elsewhere as a ReactNode. ef35c5c fix(artifacts): enable inline editing of base64 artifacts (spinnaker#7612) 97a033f chore(core/presentation): rename test file to FormValidator.spec.ts d343512 fix(core/application): add error state to application models, log exceptions (spinnaker#7599) 236e623 fix(core/presentation): remove style + wrapperClassName from HoverablePopover (spinnaker#7597) 7a81a66 feat(script): expose propertiesFile field (spinnaker#7595)
* chore(core): Bump version to 0.0.430 fc054fe feat(core/managed): visually refresh/rebrand infra details indicator (#7617) 9c8ac86 fix(core/managed): properly diff/patch mutable infra groupings (#7618) ae91048 feat(core/presentation): Create a SpelInput that supports server-side preview of spel expressions (against previous executions) 55beff7 feat(core/spel): Add a SpelService to (initially) evaluate expressions on the Server b01e6db refactor(core/presentation): use useInternalValidator in NumberInput 49f880f feat(core/presentation): Create a useInternalValidator hook for FormInputs to use e370d47 feat(core/presentation): Made useData hook default result behavior more reasonable (#7602) 9d99e04 feat(core/managed): add RESUMED resource status (#7611) f49fedf feat(core/managed): add deep links to status reference doc (#7610) 9abd35f fix(core/presentation): Handle 'null' in orEmptyString helper (#7606) e0cc0d6 feat(core/presentation): Mark all SpinFormik initialValues fields as 'touched' (#7604) 431cb86 feat(core/presentation): Add generic type param (for selected data type) to ReactSelectInput (#7603) e6280e5 fix(core/presentation): MapEditor: Make errors fill the entire row width. 3df215b fix(core/presentation): FormikFormField: call revalidate whenever internal validators change ae396e5 fix(core/presentation): pass objects through in useValidationData There's a weird case where a FormikFormField may be used for a complex object with multiple fields and/or arrays. In this case, the Field's validator should return a structured error object. This isn't fully accounted for in the FormField API. For now, pass the complex error object through as 'validationMessage'. Tag it as "hidden" so we don't try to render it elsewhere as a ReactNode. ef35c5c fix(artifacts): enable inline editing of base64 artifacts (#7612) 97a033f chore(core/presentation): rename test file to FormValidator.spec.ts d343512 fix(core/application): add error state to application models, log exceptions (#7599) 236e623 fix(core/presentation): remove style + wrapperClassName from HoverablePopover (#7597) 7a81a66 feat(script): expose propertiesFile field (#7595) * chore(amazon): Bump version to 0.0.223 3e655b9 feat(amazon/instance): add configurable exclusion rules for families + categories (#7623)
* chore(core): Bump version to 0.0.430 fc054fe feat(core/managed): visually refresh/rebrand infra details indicator (spinnaker#7617) 9c8ac86 fix(core/managed): properly diff/patch mutable infra groupings (spinnaker#7618) ae91048 feat(core/presentation): Create a SpelInput that supports server-side preview of spel expressions (against previous executions) 55beff7 feat(core/spel): Add a SpelService to (initially) evaluate expressions on the Server b01e6db refactor(core/presentation): use useInternalValidator in NumberInput 49f880f feat(core/presentation): Create a useInternalValidator hook for FormInputs to use e370d47 feat(core/presentation): Made useData hook default result behavior more reasonable (spinnaker#7602) 9d99e04 feat(core/managed): add RESUMED resource status (spinnaker#7611) f49fedf feat(core/managed): add deep links to status reference doc (spinnaker#7610) 9abd35f fix(core/presentation): Handle 'null' in orEmptyString helper (spinnaker#7606) e0cc0d6 feat(core/presentation): Mark all SpinFormik initialValues fields as 'touched' (spinnaker#7604) 431cb86 feat(core/presentation): Add generic type param (for selected data type) to ReactSelectInput (spinnaker#7603) e6280e5 fix(core/presentation): MapEditor: Make errors fill the entire row width. 3df215b fix(core/presentation): FormikFormField: call revalidate whenever internal validators change ae396e5 fix(core/presentation): pass objects through in useValidationData There's a weird case where a FormikFormField may be used for a complex object with multiple fields and/or arrays. In this case, the Field's validator should return a structured error object. This isn't fully accounted for in the FormField API. For now, pass the complex error object through as 'validationMessage'. Tag it as "hidden" so we don't try to render it elsewhere as a ReactNode. ef35c5c fix(artifacts): enable inline editing of base64 artifacts (spinnaker#7612) 97a033f chore(core/presentation): rename test file to FormValidator.spec.ts d343512 fix(core/application): add error state to application models, log exceptions (spinnaker#7599) 236e623 fix(core/presentation): remove style + wrapperClassName from HoverablePopover (spinnaker#7597) 7a81a66 feat(script): expose propertiesFile field (spinnaker#7595) * chore(amazon): Bump version to 0.0.223 3e655b9 feat(amazon/instance): add configurable exclusion rules for families + categories (spinnaker#7623)
* chore(core): Bump version to 0.0.430 fc054fe feat(core/managed): visually refresh/rebrand infra details indicator (spinnaker#7617) 9c8ac86 fix(core/managed): properly diff/patch mutable infra groupings (spinnaker#7618) ae91048 feat(core/presentation): Create a SpelInput that supports server-side preview of spel expressions (against previous executions) 55beff7 feat(core/spel): Add a SpelService to (initially) evaluate expressions on the Server b01e6db refactor(core/presentation): use useInternalValidator in NumberInput 49f880f feat(core/presentation): Create a useInternalValidator hook for FormInputs to use e370d47 feat(core/presentation): Made useData hook default result behavior more reasonable (spinnaker#7602) 9d99e04 feat(core/managed): add RESUMED resource status (spinnaker#7611) f49fedf feat(core/managed): add deep links to status reference doc (spinnaker#7610) 9abd35f fix(core/presentation): Handle 'null' in orEmptyString helper (spinnaker#7606) e0cc0d6 feat(core/presentation): Mark all SpinFormik initialValues fields as 'touched' (spinnaker#7604) 431cb86 feat(core/presentation): Add generic type param (for selected data type) to ReactSelectInput (spinnaker#7603) e6280e5 fix(core/presentation): MapEditor: Make errors fill the entire row width. 3df215b fix(core/presentation): FormikFormField: call revalidate whenever internal validators change ae396e5 fix(core/presentation): pass objects through in useValidationData There's a weird case where a FormikFormField may be used for a complex object with multiple fields and/or arrays. In this case, the Field's validator should return a structured error object. This isn't fully accounted for in the FormField API. For now, pass the complex error object through as 'validationMessage'. Tag it as "hidden" so we don't try to render it elsewhere as a ReactNode. ef35c5c fix(artifacts): enable inline editing of base64 artifacts (spinnaker#7612) 97a033f chore(core/presentation): rename test file to FormValidator.spec.ts d343512 fix(core/application): add error state to application models, log exceptions (spinnaker#7599) 236e623 fix(core/presentation): remove style + wrapperClassName from HoverablePopover (spinnaker#7597) 7a81a66 feat(script): expose propertiesFile field (spinnaker#7595) * chore(amazon): Bump version to 0.0.223 3e655b9 feat(amazon/instance): add configurable exclusion rules for families + categories (spinnaker#7623)
Depends on spinnaker/spinnaker.github.io#1585 and #7610.
Support for the newly-added
RESUMED
status — feedback on wording / etc is welcome. Until #7610 gets merged there will be an extra commit at the beginning, this PR is only one commit.