Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ecs): set loadBalancedContainer to empty when creating new targetGroupMappings #8224

Merged
merged 4 commits into from
Apr 30, 2020
Merged

fix(ecs): set loadBalancedContainer to empty when creating new targetGroupMappings #8224

merged 4 commits into from
Apr 30, 2020

Conversation

piradeepk
Copy link
Contributor

Clouddriver currently contains validation to ensure that a targetGroup is specified in order to use a loadBalancedContainer(if one is specified). When using deck, a targetGroupMapping is specified using the previous targetGroup and loadBalancedContainer properties.

This change will reset both of those properties to be empty once the new targetGroupMapping is constructed, containing the values existing in those properties.

@allisaurus
Copy link
Contributor

(adding additional context from testing) previously, if you updated from using targetGroup/loadBalancedContainer to using targetGroupMappings, Deck would wipe out targetGroup but not loadBalancedContainer, causing validation to trigger and failing a deployment with: targetGroup.not.nullable. This change correctly removes both.

@allisaurus allisaurus added the ready to merge Reviewed and ready for merge label Apr 30, 2020
@mergify mergify bot merged commit d4e5b2f into spinnaker:master Apr 30, 2020
@allisaurus
Copy link
Contributor

@mergify backport release-1.20.x

mergify bot pushed a commit that referenced this pull request Apr 30, 2020
@piradeepk
fix(ecs): set loadBalancedContainer to empty when creating new target…
739adfe 
…GroupMappings (#8224)

Co-authored-by: allisaurus <34254888+allisaurus@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit d4e5b2f)
@mergify
Copy link
Contributor

mergify bot commented Apr 30, 2020

Command backport release-1.20.x: success

Backports have been created

Hey, I reacted but my real name is @Mergifyio

@mergify mergify bot mentioned this pull request Apr 30, 2020
Merged
ethanfrogers pushed a commit that referenced this pull request May 1, 2020
@mergify
fix(ecs): set loadBalancedContainer to empty when creating new target…
edadcc6 
…GroupMappings (bp #8224) (#8227)
@piradeepk piradeepk mentioned this pull request Jun 9, 2020
Closed
@piradeepk piradeepk mentioned this pull request Aug 19, 2020
Closed
6 tasks
yunzhangit pushed a commit to yunzhangit/deck that referenced this pull request Mar 28, 2021
@mergify @yunzhangit
fix(ecs): set loadBalancedContainer to empty when creating new target…
29bca2f 
…GroupMappings (bp spinnaker#8224) (spinnaker#8227)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allisaurus allisaurus allisaurus approved these changes

Assignees
No one assigned
Labels
ready to merge Reviewed and ready for merge target-release/1.21
Projects
None yet
Milestone
No milestone
3 participants
@piradeepk @allisaurus @spinnakerbot