feat(core/presentation): add useInterval hook #8609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vigneshm
approved these changes
Oct 1, 2020
erikmunson
pushed a commit
that referenced
this pull request
Oct 1, 2020
34bc7e9 feat(core/managed): switch to abbreviated timestamp format, add version timestamps (#8610) 012b004 feat(core/managed): show failed, pending bubbles for any constraint type (#8611) 7604b3d feat(webhooks): document stausJsonPath is now optional (#8608) 0463ecb feat(core/presentation): add useInterval hook (#8609)
mergify bot
pushed a commit
that referenced
this pull request
Oct 1, 2020
…45 (#8612) * chore(appengine): publish appengine@0.0.19 d36922b feat(provider/appengine): add deploy global configuration stage (#8599) * chore(core): publish core@0.0.514 34bc7e9 feat(core/managed): switch to abbreviated timestamp format, add version timestamps (#8610) 012b004 feat(core/managed): show failed, pending bubbles for any constraint type (#8611) 7604b3d feat(webhooks): document stausJsonPath is now optional (#8608) 0463ecb feat(core/presentation): add useInterval hook (#8609) * chore(ecs): publish ecs@0.0.265 748da07 feat(ecs): Enable embedded artifacts for Deploy stage (#8603) 61cf058 feat(ecs): add Amazon ECS Cypress tests * chore(titus): publish titus@0.0.145 619ad9c (fix): Angular to react prop error (#8607)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a PR for Managed Delivery coming up in a moment that needed to run some callback code on an interval, but shouldn't be tied to any of our usual stuff for polling that tries to be clever about page visibility and online/offline states (
SchedulerFactory, etc.).useIntervalis a pretty commonly written custom hook so I didn't try to reinvent the wheel, it's pretty rudimentary. Some unit tests to go along with it as well.