feat(core/managed): show failed, pending bubbles for any constraint type #8611
Conversation
| @@ -134,14 +136,29 @@ function getArtifactStatuses({ environments }: IManagedArtifactVersion): Artifac | |||
| // NOTE: The order in which entries are added to `statuses` is important. The highest priority | |||
| // item must be inserted first. | |||
There was a problem hiding this comment.
the way i'm stacking these right now is:
- pending constraints — this feels like a 'things are actively happening and you should know about it' case
- failed constraints — it feels kind of yucky to potentially not see these if other things are pending/running, but I thought 1 was more important
- pinned state — important, but hopefully if you don't get a chance to see it here you'll see it in the overview or via our snazzy new warning card on other versions. I'm less worried about people missing this info if there are multiple status bubbles
| }); | ||
| failedConstraintTypes.forEach((type) => { | ||
| statuses.push({ appearance: 'error', iconName: getConstraintIcon(type) }); | ||
| }); |
There was a problem hiding this comment.
The way I've setup the logic here is that we will reduce all the constraints across all the environments into a list of their unique types – so let's say there are three pending manual judgements across three environments, we'll show one single pending manual judgement bubble. If there were any failed manual judgements, we'd show one single error manual judgement bubble. So you'll see that some environments have a constraint in that state, but no context about how many. Same is true for pinning right now.
Longer term we may need to think about supporting quantities on these bubbles so we could e.g. have a pending manual judgement bubble with a little "2" to indicate that there are two environments with that constraint status.
|
I thought this was going to be dependent on #8610, but I ended up being wrong. 🥳 |
34bc7e9 feat(core/managed): switch to abbreviated timestamp format, add version timestamps (#8610) 012b004 feat(core/managed): show failed, pending bubbles for any constraint type (#8611) 7604b3d feat(webhooks): document stausJsonPath is now optional (#8608) 0463ecb feat(core/presentation): add useInterval hook (#8609)
…45 (#8612) * chore(appengine): publish appengine@0.0.19 d36922b feat(provider/appengine): add deploy global configuration stage (#8599) * chore(core): publish core@0.0.514 34bc7e9 feat(core/managed): switch to abbreviated timestamp format, add version timestamps (#8610) 012b004 feat(core/managed): show failed, pending bubbles for any constraint type (#8611) 7604b3d feat(webhooks): document stausJsonPath is now optional (#8608) 0463ecb feat(core/presentation): add useInterval hook (#8609) * chore(ecs): publish ecs@0.0.265 748da07 feat(ecs): Enable embedded artifacts for Deploy stage (#8603) 61cf058 feat(ecs): add Amazon ECS Cypress tests * chore(titus): publish titus@0.0.145 619ad9c (fix): Angular to react prop error (#8607)
We've had some code for a while that will look for
manual-judgementconstraints in aPENDINGstatus and throw them into status bubbles on the version sidebar. This change expands that logic in two ways:manual-judgementFAILorOVERRIDE_FAILstatus using an error-colored bubbleAs a bonus, I also threw in a one-liner to fix the z-index issue that made for an awkward scrolling experience (before and after below)
Failed & rejected constraints
Scrolling (before and after)
cc @gcomstock