fix(core): fix issue in console log modal #9134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caseyhebebrand
approved these changes
May 5, 2021
zachsmith1
added
the
backport-candidate
|
Added label backport-candidate. (no test really needed for simple null checking) |
ranihorev
pushed a commit
that referenced
this pull request
May 5, 2021
8aeeaf7 fix(core): fix issue in console log modal (#9134) 716f7b7 fix(style): this ensure that the main div won't overflow the page (#9130) 408f0eb feat(pipeline): Show completed time in stage details (#9126) 9aeb398 chore(prettier): Just Update Prettier™️ 22859be fix(core): pushed modal overlay to the background (#9111)
ranihorev
pushed a commit
that referenced
this pull request
May 5, 2021
8aeeaf7 fix(core): fix issue in console log modal (#9134) 716f7b7 fix(style): this ensure that the main div won't overflow the page (#9130) 408f0eb feat(pipeline): Show completed time in stage details (#9126) 9aeb398 chore(prettier): Just Update Prettier™️ 22859be fix(core): pushed modal overlay to the background (#9111)
ranihorev
pushed a commit
that referenced
this pull request
May 5, 2021
8aeeaf7 fix(core): fix issue in console log modal (#9134) 716f7b7 fix(style): this ensure that the main div won't overflow the page (#9130) 408f0eb feat(pipeline): Show completed time in stage details (#9126) 9aeb398 chore(prettier): Just Update Prettier™️ 22859be fix(core): pushed modal overlay to the background (#9111)
ranihorev
pushed a commit
that referenced
this pull request
May 6, 2021
8aeeaf7 fix(core): fix issue in console log modal (#9134) 716f7b7 fix(style): this ensure that the main div won't overflow the page (#9130) 408f0eb feat(pipeline): Show completed time in stage details (#9126) 9aeb398 chore(prettier): Just Update Prettier™️ 22859be fix(core): pushed modal overlay to the background (#9111)
ranihorev
pushed a commit
that referenced
this pull request
May 6, 2021
8aeeaf7 fix(core): fix issue in console log modal (#9134) 716f7b7 fix(style): this ensure that the main div won't overflow the page (#9130) 408f0eb feat(pipeline): Show completed time in stage details (#9126) 9aeb398 chore(prettier): Just Update Prettier™️ 22859be fix(core): pushed modal overlay to the background (#9111)
mergify bot
pushed a commit
that referenced
this pull request
May 6, 2021
8aeeaf7 fix(core): fix issue in console log modal (#9134) 716f7b7 fix(style): this ensure that the main div won't overflow the page (#9130) 408f0eb feat(pipeline): Show completed time in stage details (#9126) 9aeb398 chore(prettier): Just Update Prettier™️ 22859be fix(core): pushed modal overlay to the background (#9111)
|
@Mergifyio backport release-1.26.x |
mergify bot
pushed a commit
that referenced
this pull request
May 11, 2021
(cherry picked from commit 8aeeaf7)
|
Command
|
link108
pushed a commit
that referenced
this pull request
May 11, 2021
link108
removed
the
backport-candidate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were hitting issues testing this out in 2.26 and this resolve the failed behavior we were seeing