feat: introduce a separate timeout config property for api timeouts #9498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apoorvmahajan
force-pushed
the
api_timeout
branch
from
f3d94a1
to
ce26f1d
Compare
apoorvmahajan
changed the title
dbyron-sf
approved these changes
Jul 28, 2021
apoorvmahajan
added a commit
to apoorvmahajan/spinnaker.io
that referenced
this pull request
Jul 29, 2021
* the changes from the following PRs have been added here: - spinnaker/clouddriver#5401 - spinnaker/orca#4150 - spinnaker/deck#9498
apoorvmahajan
added a commit
to apoorvmahajan/spinnaker.io
that referenced
this pull request
Jul 29, 2021
* the changes from the following PRs have been added here: - spinnaker/clouddriver#5401 - spinnaker/orca#4150 - spinnaker/deck#9498
dbyron-sf
pushed a commit
to spinnaker/spinnaker.io
that referenced
this pull request
Jul 29, 2021
* the changes from the following PRs have been added here: - spinnaker/clouddriver#5401 - spinnaker/orca#4150 - spinnaker/deck#9498
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presently, for api calls made by deck to other microservices,
pollScheduleproperty is being used. It seems like this is primarily meant for this.So this PR introduces a separate property that is solely meant for timeouts. To not make it a breaking change, this PR goes with the following
(SETTINGS.apiTimeoutMs || SETTINGS.pollSchedule || 30000)What do you think about this?