-
Notifications
You must be signed in to change notification settings - Fork 590
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(decode): Remove duplicate url decoder in ControllerSupport (#576)
A call to decode the input is not necessary since Spring decodes the path variable input by default. See Spring's RequestMappingHandlerMapping and UrlPathHelper. For example, a call to fiat `/authorize/some%2Buser@example.com` is properly decoded as `some+user@example.com` by Spring, but then decoded again via `ControllerSupport` -- the result is `some user@example.com`. This can, in certain scenarios, cause authorization lookups to return a 404. Co-authored-by: Cameron Fieber <cameron@fieber.ca>
- Loading branch information
1 parent
625d788
commit d91e70e
Showing
2 changed files
with
5 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters