fix: Fix git trigger issue caused by a misconfig of the object mapper when creating the echo retrofit service #1756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when creating the echo retrofit service Because of the misconfiguration echo was failing with GitEventHandler : Github Digest mismatch! Pipeline NOT triggered Closes spinnaker/spinnaker#6886
|
@jasonmcintosh fyi |
|
Possible to add a test for this? |
|
https://github.com/spinnaker/gate/pull/1663/files#r1227101209 is where this came in. What's interesting is the commentary - I'd GUESS that the defaults on the object mapper builder are breaking things incorrectly though this is just goofy/where. Tests/details appreciated! |
… when creating the echo retrofit service Because of the misconfiguration echo was failing with GitEventHandler : Github Digest mismatch! Pipeline NOT triggered Closes spinnaker/spinnaker#6886
|
The issue is caused by the fact that when Gate passes the payload to Echo, it sorts the keys alphabetically (this is enabled in the Gate needs to pass through the raw content without any additional parsing. |
…rdered alphabetically Closes spinnaker/spinnaker#6886
ovidiupopa07
force-pushed
the
fix-git-event-trigger
branch
from
e8169bd
to
46273b7
Compare
|
hey @jasonmcintosh / @dbyron-sf I added one test to verify that the body sent to Echo is not ordered alphabetically. |
jasonmcintosh
approved these changes
Feb 1, 2024
|
@mergify backport release-1.32.x release-1.33.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Feb 1, 2024
… when creating the echo retrofit service (#1756) * fix: Fix git trigger issue caused by a misconfig of the object mapper when creating the echo retrofit service Because of the misconfiguration echo was failing with GitEventHandler : Github Digest mismatch! Pipeline NOT triggered Closes spinnaker/spinnaker#6886 * fix: Fix git trigger issue caused by a misconfig of the object mapper when creating the echo retrofit service Because of the misconfiguration echo was failing with GitEventHandler : Github Digest mismatch! Pipeline NOT triggered Closes spinnaker/spinnaker#6886 * test: Add test verifying that the payload being sent to Echo is not ordered alphabetically Closes spinnaker/spinnaker#6886 * fix: Apply spotless checks to the test * fix: Fix failing test (cherry picked from commit 4aae98d)
mergify bot
pushed a commit
that referenced
this pull request
Feb 1, 2024
… when creating the echo retrofit service (#1756) * fix: Fix git trigger issue caused by a misconfig of the object mapper when creating the echo retrofit service Because of the misconfiguration echo was failing with GitEventHandler : Github Digest mismatch! Pipeline NOT triggered Closes spinnaker/spinnaker#6886 * fix: Fix git trigger issue caused by a misconfig of the object mapper when creating the echo retrofit service Because of the misconfiguration echo was failing with GitEventHandler : Github Digest mismatch! Pipeline NOT triggered Closes spinnaker/spinnaker#6886 * test: Add test verifying that the payload being sent to Echo is not ordered alphabetically Closes spinnaker/spinnaker#6886 * fix: Apply spotless checks to the test * fix: Fix failing test (cherry picked from commit 4aae98d)
|
Fixes bug introduced in #1663 FYI |
mergify bot
added a commit
that referenced
this pull request
Feb 1, 2024
… when creating the echo retrofit service (#1756) (#1758) * fix: Fix git trigger issue caused by a misconfig of the object mapper when creating the echo retrofit service Because of the misconfiguration echo was failing with GitEventHandler : Github Digest mismatch! Pipeline NOT triggered Closes spinnaker/spinnaker#6886 * fix: Fix git trigger issue caused by a misconfig of the object mapper when creating the echo retrofit service Because of the misconfiguration echo was failing with GitEventHandler : Github Digest mismatch! Pipeline NOT triggered Closes spinnaker/spinnaker#6886 * test: Add test verifying that the payload being sent to Echo is not ordered alphabetically Closes spinnaker/spinnaker#6886 * fix: Apply spotless checks to the test * fix: Fix failing test (cherry picked from commit 4aae98d) Co-authored-by: ovidiupopa07 <105648914+ovidiupopa07@users.noreply.github.com>
mergify bot
added a commit
that referenced
this pull request
Feb 1, 2024
… when creating the echo retrofit service (#1756) (#1757) * fix: Fix git trigger issue caused by a misconfig of the object mapper when creating the echo retrofit service Because of the misconfiguration echo was failing with GitEventHandler : Github Digest mismatch! Pipeline NOT triggered Closes spinnaker/spinnaker#6886 * fix: Fix git trigger issue caused by a misconfig of the object mapper when creating the echo retrofit service Because of the misconfiguration echo was failing with GitEventHandler : Github Digest mismatch! Pipeline NOT triggered Closes spinnaker/spinnaker#6886 * test: Add test verifying that the payload being sent to Echo is not ordered alphabetically Closes spinnaker/spinnaker#6886 * fix: Apply spotless checks to the test * fix: Fix failing test (cherry picked from commit 4aae98d) Co-authored-by: ovidiupopa07 <105648914+ovidiupopa07@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable the
ORDER_MAP_ENTRIES_BY_KEYSserialization feature since this is causing an issue in Echo : Github Digest mismatch! Pipeline NOT triggeredGithub webhook delivery
Spinnaker pipeline setup
Spinnaker pipeline triggered when the event is received
Closes spinnaker/spinnaker#6886