Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix git trigger issue caused by a misconfig of the object mapper when creating the echo retrofit service (backport #1756) #1757

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 1, 2024

This is an automatic backport of pull request #1756 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

… when creating the echo retrofit service (#1756)

* fix: Fix git trigger issue caused by a misconfig of the object mapper when creating the echo retrofit service

Because of the misconfiguration echo was failing with GitEventHandler  : Github Digest mismatch! Pipeline NOT triggered

Closes spinnaker/spinnaker#6886

* fix: Fix git trigger issue caused by a misconfig of the object mapper when creating the echo retrofit service

Because of the misconfiguration echo was failing with GitEventHandler  : Github Digest mismatch! Pipeline NOT triggered

Closes spinnaker/spinnaker#6886

* test: Add test verifying that the payload being sent to Echo is not ordered alphabetically

Closes spinnaker/spinnaker#6886

* fix: Apply spotless checks to the test

* fix: Fix failing test

(cherry picked from commit 4aae98d)
@jasonmcintosh jasonmcintosh added the ready to merge Approved and ready for merge label Feb 1, 2024
@mergify mergify bot added the auto merged label Feb 1, 2024
@mergify mergify bot merged commit edc09af into release-1.32.x Feb 1, 2024
4 checks passed
@mergify mergify bot deleted the mergify/bp/release-1.32.x/pr-1756 branch February 1, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants