Skip to content

Commit

Permalink
fix(events): rename the send events prop (#725)
Browse files Browse the repository at this point in the history
Follow up to feedback in #724.
Renaming the property to `spinnaker.build.sendEventsEnabled`, this way it is symmetric to existing properties in `igor`, e.g.:

```yaml
spinnaker:
  build:
    pollingEnabled: true
    sendEventsEnabled: false
```
  • Loading branch information
marchello2000 committed May 6, 2020
1 parent 7dd7d5b commit 59f2d21
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ protected void internalPollSingle(PollContext ctx) {
.set(0);
}

sendEvents = sendEvents && isSendingEventsEnabled();
sendEvents = sendEvents && isSendEventsEnabled();

commitDelta(delta, sendEvents);
registry
Expand Down Expand Up @@ -277,8 +277,8 @@ public Long getLastPoll() {
return lastPoll.get();
}

private boolean isSendingEventsEnabled() {
return dynamicConfigService.isEnabled("igor.build.sendEvents", true);
private boolean isSendEventsEnabled() {
return dynamicConfigService.getConfig(Boolean.class, "spinnaker.build.sendEventsEnabled", true);
}

protected @Nullable Integer getPartitionUpperThreshold(String partition) {
Expand Down

0 comments on commit 59f2d21

Please sign in to comment.