fix(events): Add dynamic config service to send events #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not currently possible to start/stop `igor` from sending events of completed builds/newly published images to `echo`. It is useful to have this functionality because igor should always be "polling" to have a local cache of "triggered" builds/images. This change allows an operator to: * have two clusters of `igor` both polling but only one sending events (i.e. triggering pipeline) * switch which cluster is sending events without generating duplicate events/double triggering
marchello2000
commented
May 5, 2020
| @@ -208,6 +219,8 @@ protected void internalPollSingle(PollContext ctx) { | |||
| .set(0); | |||
| } | |||
|
|
|||
| sendEvents = sendEvents && isSendingEventsEnabled(); | |||
There was a problem hiding this comment.
this is the actual change
robzienert
approved these changes
May 5, 2020
cfieber
approved these changes
May 5, 2020
ajordens
reviewed
May 5, 2020
| @@ -264,6 +277,10 @@ public Long getLastPoll() { | |||
| return lastPoll.get(); | |||
| } | |||
|
|
|||
| private boolean isSendingEventsEnabled() { | |||
| return dynamicConfigService.isEnabled("igor.build.sendEvents", true); | |||
There was a problem hiding this comment.
Not sure we need igor in here since the fp is going to be scoped to igor the application ... should the default be true or false? (I suppose true for backwards compatibility).
igor:
build:
sendEvents: true
The igor in that config snippet would also seem weird in igor.yml.
We do have some config under spinnaker.build tho?
There was a problem hiding this comment.
spinnaker.build.sendEvents seems a bit weird though... but it would fit with convention - will switch to that.
def want to default to true, since that's the behavior today
marchello2000
added a commit
to marchello2000/igor
that referenced
this pull request
May 6, 2020
Follow up to feedback in spinnaker#724. Renaming the property to `spinnaker.build.sendEventsEnabled`, this way it is symmetric to existing properties in `igor`, e.g.: ```yaml spinnaker: build: pollingEnabled: true sendEventsEnabled: false ```
mergify bot
pushed a commit
that referenced
this pull request
May 6, 2020
Follow up to feedback in #724. Renaming the property to `spinnaker.build.sendEventsEnabled`, this way it is symmetric to existing properties in `igor`, e.g.: ```yaml spinnaker: build: pollingEnabled: true sendEventsEnabled: false ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not currently possible to start/stop
igorfrom sending events of completed builds/newly published images toecho.It is useful to have this functionality because igor should always be "polling" to have a local cache of "triggered" builds/images.
This change allows an operator to:
igorboth polling but only one sending events (i.e. triggering pipeline)