-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support versioning of kustomization-base #121
Comments
@micnncim : Great idea! I think this would make things a lot easier for users to pin to a specific version and deliberately upgrade (rather than always pull in the latest As the idea would be for |
Glad to hear your reply!
Yeah, I agree with this idea. Tying the versions of |
@micnncim : Sounds good, thanks! I've created |
@ezimanyi Great work! I appreciate your quick response. You can close this issue anytime as it has met my request. |
@ezimanyi I think it would be better to also create GitHub releases with CHANGELOG to let users know updates. |
Yeah, that's a good point...let me create a Github action to push release notes when we publish a release. |
Thank you! Anything I can do to help? |
@micnncim : I was just going to look to see if there was a simple Github Action to create release notes on tag push. For kleat we use If you know of any such Github action, or want to look into that, it would definitely be helpful! Otherwise, I'll take a look at this later this week or early next week. |
From https://bsideup.github.io/posts/github_bots/, perhaps https://github.com/apps/release-drafter is helpful? Sample config here: https://github.com/testcontainers/testcontainers-java/blob/master/.github/release-drafter.yml |
@ezimanyi Sounds good! I recommend we use git-chglog. It's a single binary CLI tool because of written in Go, though many popular changelog generator tools are written in Ruby or JavaScript. We can easily integrate it with GitHub Actions. Actually, I use it for my personal projects with GitHub Actions. The workflow looks like:
We can generate release notes in the same format as Kleat's ones. If you don't mind, I'd like to work on this 😄 |
@micnncim : That sounds like a great plan, thanks for outlining it! I'll assign you this issue so you can implement it. Thanks! |
Now that we've merged the PR that supports the generation of release notes with GitHub Actions, let's complete this issue. To maintainers: could you create the GitHub Releases for |
@micnncim I am happy to do that; I'll close this issue once I do. |
0.1.0 and 0.2.0 have been released with changelogs! |
Proposal
It would be better to use Git tag's versioning in kustomization-base for the users.
kustomize has already supported the use of Git refs so all we need to do is to create Git tags.
Related repositories
Background
kleat would work well with kustomization-base, though it's not necessary. So I guess many kleat's users would use the base kustomization.
Currently, the users need to specify
bases
in this way, in order to use kustomization-base:This way might break the user's configurations because it always references
master
(ormain
) branch so the user's configurations will be affected if kustomization-base is broken.With versioning like below:
It allows users to use the specific version with conviction, after examining if the version works with their configurations.
References
The text was updated successfully, but these errors were encountered: