-
Notifications
You must be signed in to change notification settings - Fork 809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bakery): Clean up cached data created by Rosco. #4323
Conversation
2737390
to
b443ced
Compare
b443ced
to
4084987
Compare
Rosco PR: spinnaker/rosco#912 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one minor comment
application, | ||
it.get("pipelineConfigId"), | ||
it.get("status")); | ||
if (type.equals("orchestration")) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if type
can be null at this point, but just to avoid a possible NPE maybe you can switch the equality check to "orchestration".equals(type).
@mergify backport release-1.27.x release-1.28.x release-1.29.x |
Co-authored-by: Fernando Freire <dogonthehorizon@gmail.com> (cherry picked from commit e4973b0)
Co-authored-by: Fernando Freire <dogonthehorizon@gmail.com> (cherry picked from commit e4973b0)
✅ Backports have been created
|
Co-authored-by: Fernando Freire <dogonthehorizon@gmail.com> (cherry picked from commit e4973b0)
Description
Rosco service uses Redis for caching purposes. The records created in Redis can be up to 50MB size and will never be removed. As a result, Redis can become quite expensive. This pull request changes solve this issue.