feat(bakery): Clean up cached data created by Rosco. #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armory-abedonik
force-pushed
the
SPLAT-405
branch
2 times, most recently
from
a115e82
to
ae419df
Compare
armory-abedonik
force-pushed
the
SPLAT-405
branch
from
ae419df
to
ae47c88
Compare
sergio-quintero
approved these changes
Nov 14, 2022
ovidiupopa07
approved these changes
Nov 15, 2022
dogonthehorizon
approved these changes
Nov 17, 2022
|
@mergify backport release-1.27.x release-1.28.x release-1.29.x |
mergify bot
pushed a commit
that referenced
this pull request
Nov 23, 2022
* feat(bakery): Clean up cached data created by Rosco. * fix: typo. * feat: Add unit test. Co-authored-by: Fernando Freire <dogonthehorizon@gmail.com> (cherry picked from commit 96cd6d2)
mergify bot
pushed a commit
that referenced
this pull request
Nov 23, 2022
* feat(bakery): Clean up cached data created by Rosco. * fix: typo. * feat: Add unit test. Co-authored-by: Fernando Freire <dogonthehorizon@gmail.com> (cherry picked from commit 96cd6d2)
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 23, 2022
* feat(bakery): Clean up cached data created by Rosco. * fix: typo. * feat: Add unit test. Co-authored-by: Fernando Freire <dogonthehorizon@gmail.com> (cherry picked from commit 96cd6d2)
mergify bot
added a commit
that referenced
this pull request
Nov 23, 2022
* feat(bakery): Clean up cached data created by Rosco. * fix: typo. * feat: Add unit test. Co-authored-by: Fernando Freire <dogonthehorizon@gmail.com> (cherry picked from commit 96cd6d2) Co-authored-by: armory-abedonik <106548537+armory-abedonik@users.noreply.github.com>
mergify bot
added a commit
that referenced
this pull request
Nov 23, 2022
* feat(bakery): Clean up cached data created by Rosco. * fix: typo. * feat: Add unit test. Co-authored-by: Fernando Freire <dogonthehorizon@gmail.com> (cherry picked from commit 96cd6d2) Co-authored-by: armory-abedonik <106548537+armory-abedonik@users.noreply.github.com>
mergify bot
added a commit
that referenced
this pull request
Nov 23, 2022
* feat(bakery): Clean up cached data created by Rosco. * fix: typo. * feat: Add unit test. Co-authored-by: Fernando Freire <dogonthehorizon@gmail.com> (cherry picked from commit 96cd6d2) Co-authored-by: armory-abedonik <106548537+armory-abedonik@users.noreply.github.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rosco service uses Redis for caching purposes. The records created in Redis can be up to 50MB size and will never be removed. As a result, Redis can become quite expensive. This pull request changes solve this issue.