feat(build): add orca-integration module to exercise the just-built docker image #4721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to facilitate testing container startup
multi-arch with --load doesn't work, so add a separate step using the local platform to make an image available for testing. see docker/buildx#59
link108
approved these changes
May 7, 2024
link108
approved these changes
May 7, 2024
|
Similar to spinnaker/clouddriver#6206, there's a bug migrating from release 1.32.x to the current (10-jun-24) HEAD of master when running postgres, and there's a way to demonstrate this with an extension of these tests...but to do that we need a docker image with a HEALTHCHECK in the release-1.32.x branch... |
|
@Mergifyio backport release-1.32.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jun 10, 2024
…ocker image (#4721) * feat(docker): add HEALTHCHECK to facilitate testing container startup * feat(build): add orca-integration module to exercise the just-built docker image * feat(gha): run integration test in pr builds multi-arch with --load doesn't work, so add a separate step using the local platform to make an image available for testing. see docker/buildx#59 * feat(gha): run integration test in branch builds (cherry picked from commit b360ad5) # Conflicts: # .github/workflows/build.yml # .github/workflows/pr.yml # Dockerfile.java11.slim # Dockerfile.java11.ubuntu # Dockerfile.slim # Dockerfile.ubuntu
mergify bot
added a commit
that referenced
this pull request
Jun 10, 2024
…ocker image (backport #4721) (#4737) * feat(build): add orca-integration module to exercise the just-built docker image (#4721) * feat(docker): add HEALTHCHECK to facilitate testing container startup * feat(build): add orca-integration module to exercise the just-built docker image * feat(gha): run integration test in pr builds multi-arch with --load doesn't work, so add a separate step using the local platform to make an image available for testing. see docker/buildx#59 * feat(gha): run integration test in branch builds (cherry picked from commit b360ad5) # Conflicts: # .github/workflows/build.yml # .github/workflows/pr.yml # Dockerfile.java11.slim # Dockerfile.java11.ubuntu # Dockerfile.slim # Dockerfile.ubuntu * fix(build): resolve conflicts while backporting to release-1.32.x There are Dockerfile.java11.* files on this branch * fix(integration): add useJUnitPlatform to orca-integration.gradle so the tests actually run --------- Co-authored-by: David Byron <82477955+dbyron-sf@users.noreply.github.com> Co-authored-by: David Byron <dbyron@salesforce.com>
|
And similarly, let's backport to 1.33.x and 1.34.x so we can verify fixes there too. |
|
@Mergifyio backport release-1.33.x release-1.34.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jun 11, 2024
…ocker image (#4721) * feat(docker): add HEALTHCHECK to facilitate testing container startup * feat(build): add orca-integration module to exercise the just-built docker image * feat(gha): run integration test in pr builds multi-arch with --load doesn't work, so add a separate step using the local platform to make an image available for testing. see docker/buildx#59 * feat(gha): run integration test in branch builds (cherry picked from commit b360ad5)
mergify bot
pushed a commit
that referenced
this pull request
Jun 11, 2024
…ocker image (#4721) * feat(docker): add HEALTHCHECK to facilitate testing container startup * feat(build): add orca-integration module to exercise the just-built docker image * feat(gha): run integration test in pr builds multi-arch with --load doesn't work, so add a separate step using the local platform to make an image available for testing. see docker/buildx#59 * feat(gha): run integration test in branch builds (cherry picked from commit b360ad5)
mergify bot
added a commit
that referenced
this pull request
Jun 11, 2024
…ocker image (#4721) (#4740) * feat(docker): add HEALTHCHECK to facilitate testing container startup * feat(build): add orca-integration module to exercise the just-built docker image * feat(gha): run integration test in pr builds multi-arch with --load doesn't work, so add a separate step using the local platform to make an image available for testing. see docker/buildx#59 * feat(gha): run integration test in branch builds (cherry picked from commit b360ad5) Co-authored-by: David Byron <82477955+dbyron-sf@users.noreply.github.com>
mergify bot
added a commit
that referenced
this pull request
Jun 11, 2024
…ocker image (#4721) (#4739) * feat(docker): add HEALTHCHECK to facilitate testing container startup * feat(build): add orca-integration module to exercise the just-built docker image * feat(gha): run integration test in pr builds multi-arch with --load doesn't work, so add a separate step using the local platform to make an image available for testing. see docker/buildx#59 * feat(gha): run integration test in branch builds (cherry picked from commit b360ad5) Co-authored-by: David Byron <82477955+dbyron-sf@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, add a healthcheck to the docker images.