fix(artifact): improve error messaging for failed artifact downl… (#453)

spinnaker · Oct 23, 2019 · 00dbfde · 00dbfde
1 parent 7e5d3da
commit 00dbfde
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/...manifests/src/main/java/com/netflix/spinnaker/rosco/manifests/ArtifactDownloaderImpl.java b/...manifests/src/main/java/com/netflix/spinnaker/rosco/manifests/ArtifactDownloaderImpl.java
@@ -11,6 +11,7 @@
 import lombok.extern.slf4j.Slf4j;
 import org.apache.commons.io.IOUtils;
 import org.springframework.stereotype.Component;
+import retrofit.RetrofitError;
 import retrofit.client.Response;
 
 @Component
@@ -30,8 +31,16 @@ public void downloadArtifact(Artifact artifact, Path targetFile) throws IOExcept
       if (response.getBody() != null) {
         try (InputStream inputStream = response.getBody().in()) {
           IOUtils.copy(inputStream, outputStream);
+        } catch (IOException e) {
+          throw new IOException(
+              String.format(
+                  "Failed to read input stream of downloaded artifact: %s. Error: %s",
+                  artifact, e.getMessage()));
         }
       }
+    } catch (RetrofitError e) {
+      throw new IOException(
+          String.format("Failed to download artifact: %s. Error: %s", artifact, e.getMessage()));
     }
   }
 }