fix(artifact): improve error messaging for failed artifact downl… #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LOVE the 🏺 |
ethanfrogers
approved these changes
Oct 23, 2019
ethanfrogers
changed the title
9 tasks
opsmxdemo
pushed a commit
to OpsMx/rosco
that referenced
this pull request
Sep 15, 2020
opsmxdemo
pushed a commit
to OpsMx/rosco
that referenced
this pull request
Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: spinnaker/spinnaker#4752
When running a Bake (Manifest) stage with the Helm or Kustomize template renderers, Orca calls out to Rosco, which calls out to Clouddriver to download the input artifact. If the download fails, a non-specific "500" message is surfaced in Deck. This change adds two explicit catch blocks to the
ArtifactDownloaderImplso that the full artifact and error message are surfaced in Deck. I am still not sure why Retrofit and/or Orca's handling of Retrofit errors only surfaces "500" by default, since Clouddriver does throw a more explicit error when it fails to download an artifact -- it seems like when the error is passed between multiple microservices to get back to Orca, the message on the body of the Retrofit response is lost.Before:
After:
