Skip to content

Commit

Permalink
fix(bakeManifest): revert to set-string (#439)
Browse files Browse the repository at this point in the history
reverts a change introduced in #418 where we went from using
`--set-string` to `--set`. This change caused backwards incompaitble
changes because the parser for `--set` in helm coerces integers into
floats when it injects them into templates. `--set-string` was
introduced to fix this in helm 2.
  • Loading branch information
ethanfrogers committed Oct 7, 2019
1 parent 89c22b3 commit 357c1ae
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ public BakeRecipe buildBakeRecipe(BakeManifestEnvironment env, HelmBakeManifestR
for (Map.Entry<String, Object> entry : overrides.entrySet()) {
overrideList.add(entry.getKey() + "=" + entry.getValue().toString());
}
command.add("--set");
command.add("--set-string");
command.add(overrideList.stream().collect(Collectors.joining(",")));
}

Expand Down

0 comments on commit 357c1ae

Please sign in to comment.