fix(bakeManifest): revert to set-string #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reverts a change introduced in spinnaker#418 where we went from using `--set-string` to `--set`. This change caused backwards incompaitble changes because the parser for `--set` in helm coerces integers into floats when it injects them into templates. `--set-string` was introduced to fix this in helm 2.
|
Once merged we can backport to 1.16 and I'll follow up with a PR to preserve the |
maggieneterval
approved these changes
Oct 7, 2019
|
@spinnakerbot cherry-pick 1.16 |
spinnakerbot
pushed a commit
that referenced
this pull request
Oct 7, 2019
reverts a change introduced in #418 where we went from using `--set-string` to `--set`. This change caused backwards incompaitble changes because the parser for `--set` in helm coerces integers into floats when it injects them into templates. `--set-string` was introduced to fix this in helm 2.
|
Cherry pick successful: #440 |
louisjimenez
pushed a commit
that referenced
this pull request
Oct 7, 2019
reverts a change introduced in #418 where we went from using `--set-string` to `--set`. This change caused backwards incompaitble changes because the parser for `--set` in helm coerces integers into floats when it injects them into templates. `--set-string` was introduced to fix this in helm 2.
opsmxdemo
pushed a commit
to OpsMx/rosco
that referenced
this pull request
Sep 15, 2020
reverts a change introduced in spinnaker#418 where we went from using `--set-string` to `--set`. This change caused backwards incompaitble changes because the parser for `--set` in helm coerces integers into floats when it injects them into templates. `--set-string` was introduced to fix this in helm 2.
opsmxdemo
pushed a commit
to OpsMx/rosco
that referenced
this pull request
Sep 16, 2020
reverts a change introduced in spinnaker#418 where we went from using `--set-string` to `--set`. This change caused backwards incompaitble changes because the parser for `--set` in helm coerces integers into floats when it injects them into templates. `--set-string` was introduced to fix this in helm 2.
sitay93
pushed a commit
to spotinst/spinnaker-rosco
that referenced
this pull request
Jun 27, 2023
reverts a change introduced in spinnaker#418 where we went from using `--set-string` to `--set`. This change caused backwards incompaitble changes because the parser for `--set` in helm coerces integers into floats when it injects them into templates. `--set-string` was introduced to fix this in helm 2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reverts a change introduced in #418 where we went from using
--set-stringto--set. This change caused backwards incompaitblechanges because the parser for
--setin helm coerces integers intofloats when it injects them into templates.
--set-stringwasintroduced to fix this in helm 2.