-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kustomize): support git/repo artifact in kustomize bake manifest #449
Merged
Merged
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
24adbbb
feat(kustomize): support git/repo artifact in kustomize bake manifest
KathrynLewis df933b1
Merge branch 'master' into gitrepo-kustomize
9f128c4
address code review comments
KathrynLewis ec74473
Merge branch 'master' into gitrepo-kustomize
KathrynLewis e26c64a
Merge remote-tracking branch 'upstream/master' into gitrepo-kustomize
KathrynLewis caf7502
Merge branch 'master' into gitrepo-kustomize
38fa3f6
address code review comments
KathrynLewis e1eeab3
Merge branch 'master' of https://github.com/spinnaker/rosco into gitr…
KathrynLewis 3fef299
Merge branch 'gitrepo-kustomize' of github.com:armory-io/rosco into g…
KathrynLewis bec468a
Merge branch 'master' into gitrepo-kustomize
be530e2
Merge branch 'master' into gitrepo-kustomize
KathrynLewis 95330b6
address code review comments
KathrynLewis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we'll want a
try-with-resources
in this function, as it's directly returning theInputStream
which should remain open for the caller (whereastry-with-resources
will close it).I think what this function should do is just
return response.getBody().in()
after the null check. Then callers (including the belowdownloadArtifactToFile
) should call this function as:That means we'll have nested
try-with-resources
blocks indownloadArtifactToFile
but that's fine and the usual way of solving this.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, that makes sense--updated. I have the catches nested as well, to preserve the logic of the error messages Maggie recently added.