Improve clouddriver exception handling #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hing artifacts from clouddriver
…rRetrofitErrorHandler when talking to clouddriver spinnaker#750 changed rosco to use SpinnakerRetrofitErrorHandler when talking to clouddriver. As a consequence, exceptions changed from RetrofitError to SpinnakerException, so update the code that looked for RetrofitError, to restore the previous wrapping and error messages to rosco's callers. While we're at it, change ArtifactDownloaderImpl.downloadArtifactToFile to throw a SpinnakerException when it catches one since that seems more informative than IOException, especially since downloadArtifactToFile throws IOExceptions for other reasons.
german-muzquiz
approved these changes
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes should really have been in #750. That PR added detail from clouddriver, but at the expense of detail from rosco about the artifact and messages about helm charts and downloading. This restores the info from before that PR.
where before this PR that was: