fix(dev): Minor fixes to special cases in build_release

Fixed --nobuild option
Fixed optional directories not available.

dev/build_release.py

@@ -179,6 +179,8 @@ def determine_modules_with_debians(gradle_root):
 
 def determine_package_version(gradle_root):
   root = determine_modules_with_debians(gradle_root)
+  if not root:
+    return None
 
   with open(os.path.join(root[0], 'build', 'debian', 'control')) as f:
      content = f.read()
@@ -495,6 +497,9 @@ def start_copy_debian_target(self, name):
       pids = []
       gradle_root = self.determine_gradle_root(name)
       version = determine_package_version(gradle_root)
+      if version is None:
+        return []
+
       for root in determine_modules_with_debians(gradle_root):
         deb_dir = '{root}/build/distributions'.format(root=root)
 
@@ -567,11 +572,12 @@ def build_container_images(self):
   def build_packages(self):
       """Build all the Spinnaker packages."""
       all_subsystems = []
+      all_subsystems.extend(SUBSYSTEM_LIST)
+      all_subsystems.extend(ADDITIONAL_SUBSYSTEMS)
+
       if self.__options.build:
         # Build in parallel using half available cores
         # to keep load in check.
-        all_subsystems.extend(SUBSYSTEM_LIST)
-        all_subsystems.extend(ADDITIONAL_SUBSYSTEMS)
         weighted_processes = self.__options.cpu_ratio * multiprocessing.cpu_count()
         pool = multiprocessing.pool.ThreadPool(
             processes=int(max(1, weighted_processes)))
@@ -597,6 +603,7 @@ def build_packages(self):
   def __do_copy(self, subsys):
     print 'Starting to copy {0}...'.format(subsys)
     pids = self.start_copy_debian_target(subsys)
+
     for p in pids:
       p.check_wait()
     print 'Finished copying {0}.'.format(subsys)

dev/refresh_source.py

@@ -310,6 +310,9 @@ def pull_from_upstream_if_master(self, repository):
       repository_dir = get_repository_dir(name)
       if not os.path.exists(repository_dir):
           self.pull_from_origin(repository)
+          if not os.path.exists(repository_dir):
+            return
+
       branch = self.get_local_branch_name(name)
       if branch != 'master':
           sys.stderr.write('Skipping {name} because it is in branch={branch}.\n'