Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hardcoded absolute paths #4

Closed
oseiskar opened this issue Dec 6, 2023 · 1 comment
Closed

Fix hardcoded absolute paths #4

oseiskar opened this issue Dec 6, 2023 · 1 comment
Assignees

Comments

@oseiskar
Copy link

oseiskar commented Dec 6, 2023

Thank you for publishing the code! The performance seems great in the benchmarks. However, to improve replicability, please consider fixing the following things:

  1. Hardcoded paths to your own home / data folders:

  2. The offline script mentioned in the README (bash bash_scripts/nerfcapture2dataset.bash). It seems to contain parameters not supported by the Python script https://github.com/spla-tam/SplaTAM/blob/main/bash_scripts/nerfcapture2dataset.bash. In addition, it seems the depth data recorded by the current version of the Nerfcapture app is actually broken due to this issue How to use captured depth images? jc211/NeRFCapture#10 (comment). (produces large upscaled RGB PNGs instead of, e.g., 16-bit grayscale depth)

@Nik-V9 Nik-V9 self-assigned this Dec 6, 2023
@Nik-V9
Copy link
Contributor

Nik-V9 commented Dec 7, 2023

Hi, Thanks so much for pointing this out! We have now further cleaned up the code.

All the hardcoded paths in the configs have been fixed. The bash script has also been fixed. Please try the latest code and let us know.

NeRFCapture, by default, upscales the depth to the RGB image using nearest neighbor interpolation. You can see this happening at

sample.width, sample.height), interpolation=cv2.INTER_NEAREST)

However, we have observed that this only adds a bit of noise to the depth maps, which is fine for SplaTAM. We found the captured depth data valid, with a pixel intensity of 6553.5, corresponding to 1 meter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants