Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stats ? #21

Closed
iDentity1337 opened this issue May 12, 2016 · 6 comments
Closed

Add stats ? #21

iDentity1337 opened this issue May 12, 2016 · 6 comments

Comments

@iDentity1337
Copy link

I think you should add atleast common stats (kills, deaths, headshots, assists), with option for local storage and MySQL. But great project anyways, looking forward for great stuff.

@vanhecke
Copy link

I would much rather see a stats output in JSON if anything.

@iDentity1337
Copy link
Author

Yeah, @vanhecke, that would be good too.

@splewis
Copy link
Owner

splewis commented May 14, 2016

I've implemented the stats collection (only), which saves the stats into a keyvalue format and is accessible via the Get5_GetMatchStats native and the get5_dumpstats command.

I don't know whether I'm going to add any MySQL support or json-formatted stats, but the collection of the stats makes those easier for others.

@iDentity1337
Copy link
Author

Available in master branch?

@splewis
Copy link
Owner

splewis commented May 14, 2016

Yes.

You can see what is collected at https://github.com/splewis/get5/blob/master/scripting/include/get5.inc#L106

It's all still subject to change. I'd like to have some stocks to make getting the stats easier than having to do keyvalue iterations which can be a pain.

@splewis
Copy link
Owner

splewis commented May 16, 2016

Stats should be implemented fully now.

I've described it in https://github.com/splewis/get5/wiki/Stats

edit: I'm open to MySQL schema changes since I'm far from an expert in that area.

@splewis splewis closed this as completed May 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants